551356 - Review the timer module, jetpack-core/lib/timer.js

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Description

[Drew Willcoxon :adw]

http://hg.mozilla.org/labs/jetpack-sdk/file/tip/packages/jetpack-core/lib/timer.js

Module description from the docs:

The timer module provides access to web-like timing functionality.  [Uses nsITimer.]

Comment 1

[Erik Vold]

Minor tweak in url module, using switch statement instead of many if statements.
http://github.com/erikvold/jetpack-sdk/commit/37dfa966a6b0aa21d05b290f89fca0e9d5121a30.patch


Minor performance tweak to userPass caching in url module, no need to look up uri.userPass twice. Plus test for parsing of userPass and port info.
http://github.com/erikvold/jetpack-sdk/commit/d5c01be29ed3a5206c4b5555965ce39e892a5515.patch

Comment 2

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Given the length of time this code has been in the tree, and the exposure it has received, it doesn't seem like additional review at this point is worth the cost, with the exception of the cuddlefish module, about which concerns have been raised, so closing these bugs WONTFIX, except for that one.