Status

()

Core
Plug-ins
--
critical
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: stephend, Assigned: Benjamin Smedberg)

Tracking

({crash})

Trunk
x86
Windows 7
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

9.48 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

8 years ago
Build ID: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a3pre) Gecko/20100309 Minefield/3.7a3pre

Plug-in info:

Octoshape Streaming Services

    File: npoctoshape.dll
    Version: 20000.9.407.0
    Octoshape embedded video plugin

application/x-octoshapeplugin-client

Sorry; I don't know if this belongs in IPC, or here in Plug-ins.

STR:

1. Using Minefield, go to http://www.octoshape.com/?page=showcase/play
2. When prompted, install the Octoshape plugin and restart
3. Return to the page, and click on the "AZTV" link at the top right

Expected Results:

Content plays and the plugin is stable

Actual Results:

Plugin crashes and the notification bar appears, allowing you to reload the page.  The crash is 100% for me, and going to about:crashes lists report IDs that merely link to: http://crash-stats.mozilla.com/about/throttling
(Reporter)

Updated

8 years ago
Keywords: crash
Blocks: 478976
Does it crash if you disable OOP ?
(Reporter)

Comment 2

8 years ago
If I set |dom.ipc.plugins.enabled| to false, it no longer crashes.
(Assignee)

Comment 3

8 years ago
stephend, when you go to about:crashes how are you opening the links? If you middle-click them you get the throttling page, but if you left-click we should submit the crash.
(Assignee)

Comment 4

8 years ago
Aww, freaky:

-		mPluginIface	0x009029c0 {size=0x003c version=0x000e newp=0x67d1236c ...}	const _NPPluginFuncs *
		size	0x003c	unsigned short
		version	0x000e	unsigned short
		newp	0x67d1236c	short (char *, _NPP *, unsigned short, short, char * *, char * *, _NPSavedData *)*
		destroy	0x67d12395	short (_NPP *, _NPSavedData * *)*
		setwindow	0x00000000	short (_NPP *, _NPWindow *)*
		newstream	0x00000000	short (_NPP *, char *, _NPStream *, unsigned char, unsigned short *)*
		destroystream	0x00000000	short (_NPP *, _NPStream *, short)*
		asfile	0x00000000	void (_NPP *, _NPStream *, const char *)*
		writeready	0x00000000	int (_NPP *, _NPStream *)*
		write	0x00000000	int (_NPP *, _NPStream *, int, int, void *)*
		print	0x00000000	void (_NPP *, _NPPrint *)*
		event	0x00000000	short (_NPP *, void *)*
		urlnotify	0x00000000	void (_NPP *, const char *, short, void *)*
		javaClass	0x00000000	void *
		getvalue	0x67d12559	short (_NPP *, NPPVariable, void *)*
		setvalue	0x00000000	short (_NPP *, NPNVariable, void *)*

It's not clear to me how octoshape works if it can't handle streams, but I think that since it's always a 0x0 plugin it just doesn't care about any windowing stuff.
Assignee: nobody → benjamin
(Assignee)

Comment 5

8 years ago
Created attachment 431634 [details] [diff] [review]
Optional NPP_HandleEvent and NPP_SetWindow, rev. 1
Attachment #431634 - Flags: review?(bent.mozilla)
(Reporter)

Comment 6

8 years ago
Benjamin, when trying to submit the report, I get:

Error: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileOutputStream.init]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: file:///C:/Program%20Files/Minefield/modules/CrashSubmit.jsm :: writeSubmittedReport :: line 167"  data: no]
Source File: file:///C:/Program%20Files/Minefield/modules/CrashSubmit.jsm
Line: 167
Here is the report I get when I crash on Windows 7: http://crash-stats.mozilla.com/report/index/8c110ed7-ad7b-4459-8da6-9f76a2100310 which shows  [@ @0x0 | mozilla::plugins::PPluginModuleChild::OnCallReceived(IPC::Message const&, IPC::Message*&) ]
Attachment #431634 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/37ea3b54ad74

I didn't actually test octoshape with this fix, please retest with tomorrow's nightly and let me know whether it works or if there are additional issues.
(Reporter)

Comment 9

8 years ago
I grabbed a tinderbox nightly ( Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a3pre) Gecko/20100312 Minefield/3.7a3pre), and this is looking good; thanks!
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 10

8 years ago
Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a3pre) Gecko/20100315 Minefield/3.7a3pre; sorry for the delay.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.