find_split should call StringMatch instead of rolling its own

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

This is the !re code at the bottom of the function.
Created attachment 431682 [details] [diff] [review]
Like so
Attachment #431682 - Flags: review?(lw)

Updated

8 years ago
Attachment #431682 - Flags: review?(lw) → review+

Comment 2

8 years ago
Comment on attachment 431682 [details] [diff] [review]
Like so

Cool, any speedup?
Sure; the first dromaeo-object-regexp test (which triggers this code) ends up about 70% faster.
Pushed http://hg.mozilla.org/tracemonkey/rev/910541364acc
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 5

8 years ago
(In reply to comment #3)
> Sure; the first dromaeo-object-regexp test (which triggers this code) ends up
> about 70% faster.

That'll do :)
Er, not in m-c yet...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: fixed-in-tracemonkey

Comment 7

8 years ago
http://hg.mozilla.org/mozilla-central/rev/910541364acc
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.