551557 - Requesting hook installed into tamarin-redux and tamarin-central

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task, P1)

Description

[Brent Baker]

The tamarin team would like the following hook added to tamarin-redux and tamarin-central

[hooks]
pretxnchangegroup.general = python ./utils/hooks/general.py

Comment 1

[Dirkjan Ochtman (:djc)]

In this case, where you're running a Python script, wouldn't it be a lot easier to hook into the running Python interpreter with a function. Should be faster, at least. (You'd have to run python:utils/hooks/general.py:somefunction instead.)

Also, is that file supposed to be in the repository? That's unusual. I'd recommend putting the hooks in the separate hooks repo that Mozilla maintains.

Comment 2

[Brent Baker]

What is the repo location that other hooks are located in?

I think it would be safest to keep the hook outside of the repo that it is being executed against.

Comment 3

[Brent Baker]

Attachment: hook script

Comment 4

[Dan Schaffer]

Comment on attachment 432550 [details]
hook script

looks good.  some suggestions:  could keep hash keys in a list, we could keep some of the data in a separate csv file but may be easier to keep everything in a single script.  also may want to check exit code of hg log.  how do we know the script is working?  Could we check exit code and sys.exit("hg log not working") or something.

Comment 5

[Aravind Gottipati [:aravind]]

Is this hook ready to be installed?

Comment 6

[Brent Baker]

It was mentioned (in comment #1) that the hook could be checked into another "hooks" mercurial repo, I am just wonder what the repo is so that I can request permission to push to the repo so that we can update the script as needed.

Comment 7

[Dirkjan Ochtman (:djc)]

It lives here: http://hg.mozilla.org/hgcustom/hghooks/

Comment 8

[Brent Baker]

Attachment: v2 hook script

Tweak the hook script to check the status code of the call to 'hg log', if the status is not 0 then report script failure, but allow checkin.

Comment 9

[Brent Baker]

http://hg.mozilla.org/hgcustom/hghooks/
- is this a repo that I can get commit privileges to?
- what is a desired location for putting in a tamarin specific script?

Comment 10

[Aravind Gottipati [:aravind]]

Ted should be able to give us an answer for comment 9.

Comment 11

[(not currently active) Ted Mielczarek]

Brent: I believe anyone with access to hg.mozilla.org can land changes in hghooks. You're welcome to put any hooks that are in use on hg.mozilla.org in there. If they're in-process python hooks, then they should go in the "mozhghooks" subdir. If they're out-of-process hooks, they can just go in the top of that repo (the hg_require_single_head hook is a shell script).

Note that for convenience, everything else in that repo is licensed under the GPL.

Comment 12

[Brent Baker]

hook script added to hghooks repo: 
http://hg.mozilla.org/hgcustom/hghooks/rev/31d1fb3b3a31

Comment 13

[Aravind Gottipati [:aravind]]

Deployed hook into tamarin-central and tamarin-redux.

Comment 14

[Chris Peyer]

Attachment: Change hook script to use inline python process.

Script changed to use a single master_hook that we can then hang more hg checks too as needed.

Comment 15

[Chris Peyer]

We have changed the hook script to use inline python.  Could you please update the hgrc file in tamarin-central and tamarin-redux to now use tamarin-hook.py:master_hook :

[hooks]
pretxnchangegroup.general = python:/path/to/tamarin-hook.py:master_hook

Comment 16

[Chris Peyer]

Attachment 440807 [details] [diff] pushed to hghooks: http://hg.mozilla.org/hgcustom/hghooks/rev/23a6c22c059e

Comment 17

[Aravind Gottipati [:aravind]]

Done.

Comment 18

[Chris Peyer]

Getting the following error message (which is blocking all commits):
remote: python: can't open file '/repo/hg/libraries/mozhghooks/tamarin-hook.py:master_hook': [Errno 2] No such file or directory

Comment 19

[Aravind Gottipati [:aravind]]

Okay, talked on irc and resolved this.

Comment 20

[Felix S. Klock II [:pnkfelix, :fklock]]

Aravind: Hey, I updated the hook for Bug 744427; can you redeploy hook (into tamarin-central and tamarin-redux).

Comment 21

[(not currently active) Ted Mielczarek]

Please file a new server ops bug rather than reuse an old one. (For one thing, Aravind no longer works for Mozilla.)

Comment 22

[Felix S. Klock II [:pnkfelix, :fklock]]

Filed re-request as Bug 744777.

Comment 23

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/60e544b45fe0
https://hg.mozilla.org/hgcustom/version-control-tools/rev/53ac40974e7e