Closed Bug 551585 Opened 10 years ago Closed 10 years ago

Remove copyright strings in UI

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(thunderbird3.1 beta2-fixed)

RESOLVED FIXED
Thunderbird 3.1b2
Tracking Status
thunderbird3.1 --- beta2-fixed

People

(Reporter: unghost, Assigned: unghost)

Details

Attachments

(1 file, 3 obsolete files)

Attached patch Fix v.1 (obsolete) — Splinter Review
This is port of Firefox Bug 536336 to Thunderbird
Attachment #431736 - Flags: review?(bugzilla)
Attached patch Fix v.2 (obsolete) — Splinter Review
Attachment #431736 - Attachment is obsolete: true
Attachment #431742 - Flags: review?(bugzilla)
Attachment #431736 - Flags: review?(bugzilla)
Don't suppose you would like to save yourself some relocalizing time by moving trademarkText into brand.dtd where it really belongs, while you're at it?
Comment on attachment 431742 [details] [diff] [review]
Fix v.2

(In reply to comment #2)
> Don't suppose you would like to save yourself some relocalizing time by moving
> trademarkText into brand.dtd where it really belongs, while you're at it?
Will do.
Attachment #431742 - Attachment is obsolete: true
Attachment #431742 - Flags: review?(bugzilla)
Attached patch Fix v.3 (obsolete) — Splinter Review
Assignee: nobody → unghost
Status: NEW → ASSIGNED
Attachment #431906 - Flags: review?(bugzilla)
Comment on attachment 431906 [details] [diff] [review]
Fix v.3

So it appears that unbranded builds will suffer from the same bug as bug 544390. So I think we need to port that as well.

If you could do that asap, that'd be great, if not, I'll figure out if we can land this before the string freeze for b1 (hence leaving review request open for now).
Attached patch Fix v.4Splinter Review
(In reply to comment #5)
> (From update of attachment 431906 [details] [diff] [review])
> So it appears that unbranded builds will suffer from the same bug as bug
> 544390. So I think we need to port that as well.
> 
> If you could do that asap, that'd be great, if not, I'll figure out if we can
> land this before the string freeze for b1 (hence leaving review request open
> for now).
Here is patch with fix ported from Bug 544390. I don't have access to Mac, so I can't test it.
Attachment #431906 - Attachment is obsolete: true
Attachment #434280 - Flags: review?(bugzilla)
Attachment #431906 - Flags: review?(bugzilla)
Comment on attachment 434280 [details] [diff] [review]
Fix v.4

Thanks for the update. After checking the dialog I changed the min-width to 298px to avoid white lines down either side of the image (and updated the comment). I suspect we've probably got some different padding or something somewhere. However, it works for now and means we can get the strings landed before we hit b2.

Thanks for the patch and updates.
Attachment #434280 - Flags: review?(bugzilla) → review+
Checked in (with the mentioned change):
http://hg.mozilla.org/comm-central/rev/3edb03b2a556
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
You need to log in before you can comment on or make changes to this bug.