551585 - Remove copyright strings in UI

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Alexander L. Slovesnik]

Attachment: Fix v.1

This is port of Firefox Bug 536336 to Thunderbird

Comment 1

[Alexander L. Slovesnik]

Attachment: Fix v.2

Comment 2

[Phil Ringnalda (:philor)]

Don't suppose you would like to save yourself some relocalizing time by moving trademarkText into brand.dtd where it really belongs, while you're at it?

Comment 3

[Alexander L. Slovesnik]

Comment on attachment 431742 [details] [diff] [review]
Fix v.2

(In reply to comment #2)
> Don't suppose you would like to save yourself some relocalizing time by moving
> trademarkText into brand.dtd where it really belongs, while you're at it?
Will do.

Comment 4

[Alexander L. Slovesnik]

Attachment: Fix v.3

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 431906 [details] [diff] [review]
Fix v.3

So it appears that unbranded builds will suffer from the same bug as bug 544390. So I think we need to port that as well.

If you could do that asap, that'd be great, if not, I'll figure out if we can land this before the string freeze for b1 (hence leaving review request open for now).

Comment 6

[Alexander L. Slovesnik]

Attachment: Fix v.4

(In reply to comment #5)
> (From update of attachment 431906 [details] [diff] [review])
> So it appears that unbranded builds will suffer from the same bug as bug
> 544390. So I think we need to port that as well.
> 
> If you could do that asap, that'd be great, if not, I'll figure out if we can
> land this before the string freeze for b1 (hence leaving review request open
> for now).
Here is patch with fix ported from Bug 544390. I don't have access to Mac, so I can't test it.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 434280 [details] [diff] [review]
Fix v.4

Thanks for the update. After checking the dialog I changed the min-width to 298px to avoid white lines down either side of the image (and updated the comment). I suspect we've probably got some different padding or something somewhere. However, it works for now and means we can get the strings landed before we hit b2.

Thanks for the patch and updates.

Comment 8

[Mark Banner (:standard8)]

Checked in (with the mentioned change):
http://hg.mozilla.org/comm-central/rev/3edb03b2a556