Closed Bug 551608 Opened 16 years ago Closed 10 years ago

Test that cleanup of experiment handlers can't leak

Categories

(Mozilla Labs Graveyard :: Test Pilot, defect, P1)

Product:
Mozilla Labs Graveyard
Component:
Test Pilot
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: jono, Assigned: jono)

Details

(Whiteboard: extension-core, api, handlers)

To guard against memory leaks (especially to guard against keeping window references around!) it would be better if the cleanup of all observers registered by a study was done in the extension, not the experiment. It's also less boilerplate to write and review in each extension, since we just have to do it once. I wonder if this may be related to the cause of the memory leak reported in 515132 ?
Priority: -- → P1
Whiteboard: extension-core, api, handlers
Target Milestone: 0.1 → 1.0
Severity: normal → major
Target Milestone: 1.0 → 1.2
Target Milestone: 1.2 → 1.3
Cleanup is now being done in the base_study_classes.js, which tracks all listeners registered and is common to all studies but is on the server side. I think this is an acceptable solution. We should still do some testing to verify that we can't accidentally create a situation where something doesn't get cleaned up. (Changing name of this bug to reflect this)
Summary: Do cleanup of experiment's handlers in the extension, not the experiment code → Test that cleanup of experiment handlers can't leak
Target Milestone: 1.3 → 1.1
Severity: major → normal
Target Milestone: 1.1 → 1.2
Target Milestone: 1.2 → 1.3
Product: Mozilla Labs → Mozilla Labs Graveyard
decommissioned
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.