Closed Bug 551677 Opened 10 years ago Closed 10 years ago

Gloda could provide ability to force indexing of all messages in a folder, even non-dirty indexed ones

Categories

(MailNews Core :: Database, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1b2

People

(Reporter: asuth, Assigned: asuth)

Details

(Whiteboard: [gloda key])

Attachments

(1 file)

This patch makes GlodaMsgIndexer.indexFolder take a second options argument where {force: true} can be specified.  This will result in gloda indexing all the messages, even when they have already been indexed.  A callback argument is also provided.

A unit test for force is provided.  I also ended up cleaning up test_index_sweep_folder.js which was basically an abandoned stub.  (I thought I was going to put the test in there but it ended up not making sense).
Attachment #431848 - Flags: review?(mixedpuppy)
Attachment #431848 - Flags: review?(mixedpuppy) → review+
pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/6417f114db07
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
After discussion with Shane about an edge case gap, I made a minor fix to cover cases where indexFolder is invoked on folders that shouldIndexFolder returns false for.  The original expectation was that no one would do this, but there's no harm in handling it.

pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/defb1451fce4
You need to log in before you can comment on or make changes to this bug.