551677 - Gloda could provide ability to force indexing of all messages in a folder, even non-dirty indexed ones

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

Attachment: v1 make indexFolder support a force option

This patch makes GlodaMsgIndexer.indexFolder take a second options argument where {force: true} can be specified.  This will result in gloda indexing all the messages, even when they have already been indexed.  A callback argument is also provided.

A unit test for force is provided.  I also ended up cleaning up test_index_sweep_folder.js which was basically an abandoned stub.  (I thought I was going to put the test in there but it ended up not making sense).

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/6417f114db07

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

After discussion with Shane about an edge case gap, I made a minor fix to cover cases where indexFolder is invoked on folders that shouldIndexFolder returns false for.  The original expectation was that no one would do this, but there's no harm in handling it.

pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/defb1451fce4