551682 - User is not redirected to Contribute screen when an add-on has a EULA

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Chris Bloom]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729)
Build Identifier: 

In my extension's Contribute section, I have chosen the option "Ask after users start downloading this add-on". However, my add-on also has a EULA so when a user clicks the "Add to Firefox" button they are taken first to the policy screen. From there, clicking on the "Accept and Install" button triggers the install, but it doesn't send the user to the contribute page afterward.

Reproducible: Always

Steps to Reproduce:
1. Go to https://addons.mozilla.org/en-US/firefox/addon/2608/
2. Click "Add to Firefox"
3. Click the "Accept and Install" button if you agree to my awesome EULA

Actual Results:  
Add-on install is triggered, but contribute page doesn't appear

Expected Results:  
User should be redirected to my contribute page according to the option I've selected in the Contributions form in the Add-on Developer Hub

Confirmed in Firefox 3.5.8 on Mac and Firefox 3.6 on Windows

Comment 1

[krupa raj[:krupa]]

can confirm

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

In-litmus+: https://litmus.mozilla.org/show_test.cgi?id=11589

Comment 3

[Jeff Balogh (:jbalogh)]

Are we ok waiting for zamboni buttons on this one?

Comment 4

[Justin Scott [:fligtar]]

(In reply to comment #3)
> Are we ok waiting for zamboni buttons on this one?

yes

Comment 5

[Jeff Balogh (:jbalogh)]

This works in zamboni via bug 544508.

Chris: note that this won't get fixed live until we start pushing out zamboni pages.

Comment 6

[Chris Bloom]

Thanks everyone! That was quick :)

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Chris: you should be able to test this at https://preview.addons.mozilla.org/z/en-US/firefox/addon/2608/; QA will take a look later, too, but it'd be nice to have you look :-)

Comment 8

[Jeff Balogh (:jbalogh)]

I broke this recently by caching the button too aggressively, let me fix that.

Comment 9

[Chris Bloom]

It appeared to work for me. (I say appeared because I didn't see the actual EULA appear and the following "About" screen was empty, but technically it did do what I expected.)

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; after clicking the button, I'm taken to https://preview.addons.mozilla.org/z/en-US/firefox/addon/2608/eula/47740?src=addondetail, and then on post-back, to https://preview.addons.mozilla.org/z/en-US/firefox/addon/2608/developers