551720 - Tracking bug for Funnelcake builds

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rafael Ebron (:rebron)]

This bug is track items we need to create Funnelcake builds.

1) Add/set parameters for urls Start and What's New via a distribution.ini or .js file
2) Hook up "cancel install" and "uninstall surveys"
2a) Create cancel install and uninstall surveys
3) Add additional parameters for autoconfig initiate, fail, and success

Comment 1

[Mark Banner (:standard8)]

Adding dependency on bug 550312 as that's dealing with the cancel install surveys.

Comment 2

[David Ascher (:davida)]

I'm not convinced we need to block funnelcake on the cancel-install survey.  Do we?

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> I'm not convinced we need to block funnelcake on the cancel-install survey.  Do
> we?

Well, you'd be able to tell that people have at least started running the installer and then decided to abort (versus just downloading Thunderbird and never finding the installer to be able to run it).

Comment 4

[Rafael Ebron (:rebron)]

Attachment: distribution.ini file

Comment 5

[Mark Banner (:standard8)]

Attachment: Patch for repack scripts.

I think this patch does everything we need it to. It would be have been easier if we had supported distribution.ini fully as we wouldn't have to set so much in an extra preferences file. However, I think this is working. I'll add steps to how to do the repack in a moment.

Comment 6

[Mark Banner (:standard8)]

Assigning to gozer for him to do the repacks, and here's how:

1) On a Mac box ensure that there is a 7zip executable in the path.
- I used http://www.macupdate.com/info.php/id/19139
- I suggest gozer uses one of the Mac minis as they have 7zip & everything else already installed.

2) Clone http://hg.mozilla.org/build/partner-repacks/

3) Apply attachment 437575 [details] [diff] [review] to the cloned repo. Note: don't push it to the repo, it isn't in a fit state for that.

4) cd into partner-repacks/scripts

5) Run the repack script:

# ./partner-repacks.py --version=3.0.4 --pkg-dmg=<path to a mozilla-1.9.1 directory>build/package/mac_osx/pkg-dmg

6) This will then produce the repacked builds into the partner-repacks/scripts
/repacked_builds directory.

7) Upload the builds to ftp, in this case create a partner_repacks directory under:

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/3.0.4-candidates/build1/unsigned/

and then upload the contents of the repacked_builds/3.0.4/build1 directory straight to ftp so that we get:

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/3.0.4-candidates/build1/unsigned/partner_repacks/funnelcake/{linux-i686,mac,win32} etc

This includes all three platforms. I believe they are initially generated from unsigned, but lets get the unsigned checked first and we can sign them later.


For future reference, Firefox automates all of this as part of its partner repacks builds and we could potentially do the same. xref:

http://hg.mozilla.org/build/buildbotcustom/file/9726abec8642/process/factory.py#l6601

Comment 7

[Mark Banner (:standard8)]

Whilst I'm thinking about it, things we should be checking on these builds:

- Preferences set correctly when app loading (see the funnelcake.js file in attachment 437575 [details] [diff] [review]).

- Account wizard still works correctly.

- Start & What's New pages still work correctly.

- Windows installation wizard: Check that aborting the installation gives a prompt to go to a survey page.

- Windows uninstall wizard: Check that an uninstall survey is offered on Windows OS that are older than Vista. Note, this should be offered even if we're not a funnelcake build. It isn't offered on Vista or later - bug 557826.

Comment 8

[Philippe M. Chiasson (:gozer)]

(In reply to comment #6)
> Assigning to gozer for him to do the repacks, and here's how:
> 
> ...

> and then upload the contents of the repacked_builds/3.0.4/build1 directory
> straight to ftp so that we get:
> 
> http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/3.0.4-candidates/build1/unsigned/partner_repacks/funnelcake/{linux-i686,mac,win32}

Builds are up.

Comment 9

[Ludovic Hirlimann [:Usul]]

(In reply to comment #7)
> Whilst I'm thinking about it, things we should be checking on these builds:
> 
> - Preferences set correctly when app loading (see the funnelcake.js file in
> attachment 437575 [details] [diff] [review]).

They're good.

> - Account wizard still works correctly.

Does tried twice with two different accounts.
 
> - Start & What's New pages still work correctly.

Start page is ok.
 
> - Windows installation wizard: Check that aborting the installation gives a
> prompt to go to a survey page.

It does.
 
> - Windows uninstall wizard: Check that an uninstall survey is offered on
> Windows OS that are older than Vista. Note, this should be offered even if
> we're not a funnelcake build. It isn't offered on Vista or later - bug 557826.

Works for me.

Comment 10

[Mark Banner (:standard8)]

I'm calling this fixed, as we did complete the first round of funnelcake builds. Bug 563138 is going to take on making them easier to do.