Closed
Bug 551767
Opened 14 years ago
Closed 14 years ago
Run mochitest-ipcplugins with the pref flipped to false
Categories
(Release Engineering :: General, defect, P3)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ted, Assigned: catlee)
Details
(Whiteboard: [simple])
Attachments
(1 file)
|
918 bytes,
patch
|
ted
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
Since we enabled OOPP by default on trunk, mochitest-ipcplugins is effectively duplicating part of mochitest-plain. We could disable that test suite, or, as bsmedberg suggests, we could flip the pref the other way (to false), so we get test coverage of the in-process plugin codepaths. I think that makes sense, and we should do that.
|
Assignee | |
Comment 1•14 years ago
|
||
Relevant code is here: http://hg.mozilla.org/build/buildbotcustom/file/tip/steps/unittest.py#l519 Just set --setprof=dom.ipc.plugins.enabled=false
Whiteboard: [simple]
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → catlee
Priority: -- → P3
|
|
Assignee | |
Comment 2•14 years ago
|
||
This will make the mochitest-ipcplugins test run with the pref set to False, and the mochitest-plain test run with the pref set to its default value. It will have this affect on all branches.
Attachment #432797 -
Flags: review?(ted.mielczarek)
|
Reporter | |
Updated•14 years ago
|
Attachment #432797 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 432797 [details] [diff] [review] Flip pref for ipcplugins test changeset: 653:b787f162e5eb
Attachment #432797 -
Flags: checked-in+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Latest tests are running properly
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•