Closed Bug 55179 Opened 24 years ago Closed 24 years ago

Autocomplete ignores user menu pick

Categories

(SeaMonkey :: UI Design, defect, P3)

Product:
SeaMonkey
Component:
UI Design
Platform:
x86
All
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jwbaker, Assigned: bugzilla)

References

Details

(Keywords: regression, Whiteboard: [rtm++])

Attachments

(2 files)

Patch to make mouse picking work in autocomplete popup
1.75 KB, patch
Details | Diff | Splinter Review
Original patch + correction for selectedItemIndex
2.23 KB, patch
Details | Diff | Splinter Review 
The autocomplete drop-down menu is ignoring the user's selection.  Linux
2000-10-03-21 M18.  To reproduce:

1) Visit http://www.mozillazine.org/ using the URL bar
2) Visit http://www.mozilla.org/ using the URL bar
3) In the URL bar, type http://www.moz
4) A menu should pop up that looks like so:

--------------------
www.mozillazine.org
www.mozilla.org
--------------------

5) Using the mouse, pick the second entry

The result is that the URL bar reads "www.moz[illazine.org]" where the bracketed
part is highlighted.  Ubviously it should read "www.mozilla.org" with nothing
highlighted and the cursor at the end of the string.
OS -> All according to #mozilla
OS: Linux → All
->xpapps
Assignee: trudelle → don
Component: XP Toolkit/Widgets → XP Apps
QA Contact: jrgm → sairuh
QA Contact: sairuh → claudius
CCing ducarroz and hyatt since they seem to pretty well own url autocompletion.

I have a patch for this, and I will attach it here.  Please give this patch a
preliminary review.  I have tested it and it works without ill effects on Linux
2000-10-12-06-MTrunk build.
Keywords: patch, review
*** Bug 56485 has been marked as a duplicate of this bug. ***
The problem now occurs on the branch too. We must fix that for RTM!
Keywords: regression, rtm
Was still working yesterday on the branch!
Assignee: don → ducarroz
Status: NEW → ASSIGNED
Target Milestone: --- → M18
The patch is good except it doesn't set the the var selectedItemIndex. This is
need for keyboard navigation after the fact. I'll attach a new patch that
correct that.
Whiteboard: Fix in hand, seeking review...
I have reviewed the patch r=radha
also, R=ducarroz for the original part of the patch.

SR=alecf
Whiteboard: Fix in hand, seeking review... → Fix in hand, reviewed (normal & super)
marking rtm+
Whiteboard: Fix in hand, reviewed (normal & super) → [rtm+]Fix in hand, reviewed (normal & super)
please, please PDT, give me a double plus!
Wasn't sure if this was serious enough, so I played with it a little, and
autocomplete ranges from working, to completely not working, to sort of working.
Marking rtm++ since the severity looks worse to me than is described here.
Whiteboard: [rtm+]Fix in hand, reviewed (normal & super) → [rtm++]Fix in hand, reviewed (normal & super)
Phil, the only problem this patch will fix is that you cannot use the mouse on 
the dropdown list to select a result. Do you see other problems?
Fix checked in the branch only. For some reason, I cannot check in the trunk.
Whiteboard: [rtm++]Fix in hand, reviewed (normal & super) → [rtm++]Fixed in branch only, got trouble with trunk!
Fis checked in the trunk too.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Whiteboard: [rtm++]Fixed in branch only, got trouble with trunk! → [rtm++]
THANKS jwbaker@acm.org for providing the patch.
*** Bug 56611 has been marked as a duplicate of this bug. ***
*** Bug 57130 has been marked as a duplicate of this bug. ***
VERIFIED Fixed with 2000102509 builds
adding vtrunk keyword so this can get verified on the trunk.
Keywords: vtrunk
This does not seem to be fixed for me with 102708 mozilla trunk build.  It works
if I arrow down and enter on the second item but it does not work if I click the
second item with the mouse.
Working fine on my Linux trunk build 10-27-06 (which has no build ID in the
title bar, grr.)

The URL from the picklist doesn't load automatically, nor would I want it to.
But it is placed in the URL bar with the cursor at the end.  What behavior are
you seeing?
*** Bug 58280 has been marked as a duplicate of this bug. ***
This doesn't work on the 102806 build (i686-linux).

Neither for the URL bar, or the To: field in MailNews.
To Clarify:
In the 102806 (Linux i686) build I still get the old style behaviour: When I
type in a partial URL (or e-mail address), I get the pop-up, and if I select an
item in that pop-up, nothing changes in the URL bar (or To: field).

Regression?
I'm still seeing this problem (clicking on an entry in the autocomplete pop-up,
yielding no result), in the 2000-10-30-08 build on i386-linux.

Arrow keys still work fine.
Well, the compose window autocomplete works fine on Linux using 2000102809 builds.
Is there something I need to do, to get this to work? I type in a name, in the
To: field, and when the pop-up appears, I select one of the entries with the
*mouse*, and click on it.

The pop-up disappears, but the selected address does not appear on the To: line.
Only whatever I had typed is there.

The Arrow keys are working fine.
which theme are your using?
Per Reedtz Thomsen, I'm not sure why you are seeing this problem.

Ducarroz, I tested on both themes and it WFM!
I was using the Modern Theme, but I tried this in the Classic as well. Same results.

I tried removing my .mozilla directory, and re-converted from NSCP 4.x. Same result.

no idea what to do next... I'll keep looking at this...
Today's build (10/31 2000, but no build tag in the window bar), WFM.

Go figure.
Autocomplete no longer working in Composition of MailNews in Build ID:
2000103020 on Windows NT 4.0 SP 5.

Arrows work fine, but mouse selection fails.

MKB
Here today, gone tomorrow.

The 2000-11-01-08 build for i686 Linux, doesn't work. Yesterday's build worked fine.

Looks like we get some problem on the trunk with this patch. See bug 60015 for
more detail...
ducarroz is going to re-land this on the trunk.

r=sspitzer on the patch.

alecf, can you sr= again?
mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: