551851 - Add Services.jsm goodness to login manager

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Bug 512784 added Services.jsm, we should use this goodness in login manager code.

Untested (waiting for my build to finish) but is simple enough.

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 432024 [details] [diff] [review]
Patch v.1

r=zpao on the password manager part. I assume somebody else needs to give the nod to adding console to services...

Comment 2

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

Oops. Took out a QueryInterface I shouldn't have. xpcshell and mochitests now all pass.

Over to vlad for the change to Services.jsm (bottom of patch).

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 432040 [details] [diff] [review]
Patch v.2

>diff --git a/toolkit/components/passwordmgr/src/crypto-SDR.js b/toolkit/components/passwordmgr/src/crypto-SDR.js

>     init : function () {
>         // Connect to the correct preferences branch.
>         this._prefBranch = Cc["@mozilla.org/preferences-service;1"].
>                            getService(Ci.nsIPrefService);
>         this._prefBranch = this._prefBranch.getBranch("signon.");

Missed this before - Services.prefs this one too.

Comment 4

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/b264a7e3c0f5

(with extra change from comment 3)

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #2)
> Took out a QueryInterface I shouldn't have.

Why not? Services.jsm seems to do it already...

Comment 6

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #5)
> (In reply to comment #2)
> > Took out a QueryInterface I shouldn't have.
> 
> Why not? Services.jsm seems to do it already...

Services.jsm QIs Services.prefs to nsIPrefBranch2, but getBranch returns an nsIPrefBranch, so that needs to be QIed.

Why does Services.jsm even QI to nsIPrefBranch2? I don't think that should do anything, let alone work...

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> Services.jsm QIs Services.prefs to nsIPrefBranch2, but getBranch returns an
> nsIPrefBranch, so that needs to be QIed.

Right, I missed the getBranch...

> Why does Services.jsm even QI to nsIPrefBranch2? I don't think that should do
> anything, let alone work...

It's there to enable Services.prefs.add/removeObserver, which works fine.

Comment 8

[Justin Dolske [:Dolske]]

(In reply to comment #7)

> Right, I missed the getBranch...

I'm glad I wasn't the only one to make this mistake. ;)