Closed
Bug 551899
Opened 13 years ago
Closed 13 years ago
Cannot set Orientation can Page size from Print Dialog/Page Setup tab.
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a4
Tracking | Status | |
---|---|---|
status1.9.2 | --- | .9-fixed |
People
(Reporter: khadgaray, Assigned: khadgaray)
References
Details
Attachments
(1 file, 1 obsolete file)
1.26 KB,
patch
|
karlt
:
review+
christian
:
approval1.9.2.7-
christian
:
approval1.9.2.9+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100216 Fedora/3.5.8-1.fc12 Firefox/3.5.8 GTB6 AutoPager/0.5.2.2 (http://www.teesoft.info/) Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100216 Fedora/3.5.8-1.fc12 Firefox/3.5.8 GTB6 AutoPager/0.5.2.2 (http://www.teesoft.info/) Cannot set Orientation can Page size from Print Dialog/Page Setup tab. I have to use "Page Setup" dialog from File menu, which is rather cumbersome. Reproducible: Always Steps to Reproduce: 1. Click on File->Print->Page Setup Actual Results: Orientation and Page size is disabled Expected Results: I should be able to change Orientation and Page size, from Print dialog gtk_print_unix_dialog_set_embed_page_setup was added with 2.18.
Assignee | ||
Comment 1•13 years ago
|
||
Component: General → Widget: Gtk
Product: Firefox → Core
QA Contact: general → gtk
Updated•13 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → 1.9.2 Branch
Updated•13 years ago
|
Version: 1.9.2 Branch → Trunk
Comment 2•13 years ago
|
||
Comment on attachment 432082 [details] [diff] [review] set gtk_print_unix_dialog_set_embed_page_setup to TRUE Can you please check this one?
Attachment #432082 -
Flags: review?(roc)
Updated•13 years ago
|
Assignee: nobody → khadgaray
Attachment #432082 -
Flags: review?(roc) → review?(karlt)
Comment on attachment 432082 [details] [diff] [review] set gtk_print_unix_dialog_set_embed_page_setup to TRUE looks ok, but I'm a bit worried that this will build a link-time dependency on GTK 2.18, which we might not want. I can never remember the GTK versioning story...
Comment 4•13 years ago
|
||
Isn't there a GObject property you could set? Then you could just check it at runtime (gtk_major_version, gtk_minor_version). That's what I did when new GTK's supported Selection. But is that all there needs to be done? There was a lot more work to get the original page setup integrated with Mozilla...
Comment 5•13 years ago
|
||
Comment on attachment 432082 [details] [diff] [review] set gtk_print_unix_dialog_set_embed_page_setup to TRUE Thanks for the patch. Usually we ensure that Gecko builds against GTK+-2.10 or newer, but, even when build against older libraries, still takes advantage of newer features where possible when run against newer libraries. The easiest way to do this here would be to set the "embed-page-setup" property. Still the property should only be set when run against versions of GTK that support the property. There's already a suitable version check here, so it's probably easiest to simply add to the g_object_set list, with additions to the comments. http://hg.mozilla.org/mozilla-central/annotate/15cb4be209b3/widget/src/gtk2/nsPrintDialogGTK.cpp#l299
Attachment #432082 -
Flags: review?(karlt)
Comment 6•13 years ago
|
||
Thanks. There is a version with the requested change.
Attachment #432082 -
Attachment is obsolete: true
Attachment #434195 -
Flags: review?(karlt)
Updated•13 years ago
|
Attachment #434195 -
Flags: review?(karlt) → review+
Comment 8•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1daf1dc743c2
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
Comment 9•12 years ago
|
||
Comment on attachment 434195 [details] [diff] [review] v2 Would like to get this in, we have a customer request for this against our packages (note: this needs the patch from bug 545502 to land first, I've already requested approval there).
Attachment #434195 -
Flags: approval1.9.2.7?
Comment 10•12 years ago
|
||
Comment on attachment 434195 [details] [diff] [review] v2 a=LegNeato for 1.9.2.8. Please land this on mozilla-1.9.2 default.
Attachment #434195 -
Flags: approval1.9.2.8+
Attachment #434195 -
Flags: approval1.9.2.7?
Attachment #434195 -
Flags: approval1.9.2.7-
Comment 11•12 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b374c411830c
status1.9.2:
--- → .8-fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•