Closed Bug 551901 Opened 14 years ago Closed 12 years ago

Test suite should not delete database at the end of FORCE_DB=yes run

Categories

(addons.mozilla.org Graveyard :: Code Quality, defect)

Product:
addons.mozilla.org Graveyard
Component:
Code Quality
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: wenzel, Assigned: wenzel)

Details

(Whiteboard: [z]) 

We avoid wiping our test database unless FORCE_DB=indeed is set.

However, at the end of such a FORCE_DB run, the test database is wiped *again*, which results in the next run after that needing to recreate the database as well.

The test db should only ever be deleted, in the beginning, when FORCE_DB is set. Subsequent runs without that flag should find the database from the last test run.
That's a good idea.
Assignee: nobody → fwenzel
BTW, these days I just do `echo drop database test_zamboni | mysql` instead of using FORCE_DB.  The db gets created by never gets dropped like it would with FORCE_DB.
I think Jeff's workaround is good enough.  FORCE_DB is really just forcing Django to do it's teardown rah-rah dance.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.