551938 - AMO links produce error message "Missing argument: addon_id"

Status: RESOLVED WORKSFORME

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Patrick Finch]

Links to AMO for en-US seem to be failing.  Links without a trailing slash, such as:

https://addons.mozilla.org/en-US/firefox/addon/10900
https://addons.mozilla.org/en-US/firefox/addon/12559 

produce the error message, "Missing argument: addon_id"

if the URLs are formed with a trailing /, no error encountered.

Comment 1

[David Tenser [:djst]]

I can confirm this. It only seems to happen on en-US, not e.g. sv-SE.

STR:

1. Visit https://addons.mozilla.org/en-US/firefox/
2. Search for personas
3. Click the Personas Plus link

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

WFM here in the States; any chance either of your could download/install Live HTTP Headers and attach its output for the STR in comment 0 (as a text/plain attachment, please).  Thanks!

Comment 3

[Wil Clouser [:clouserw]]

WFM as well

Comment 4

[Camille]

I have the same bug, but it doesn't depend on the trailing slash.

To reproduce it, just go to this page and refresh :

https://addons.mozilla.org/en-US/firefox/addon/8174/

On 6 refresh I add 2 times the errors.

Comment 5

[Camille]

(In reply to comment #0)
> Links to AMO for en-US seem to be failing.  Links without a trailing slash,
> such as:
> 
> https://addons.mozilla.org/en-US/firefox/addon/10900
> https://addons.mozilla.org/en-US/firefox/addon/12559 
> 
> produce the error message, "Missing argument: addon_id"
> 
> if the URLs are formed with a trailing /, no error encountered.

This is the headers I got :

https://addons.mozilla.org/en-US/firefox/addon/8174/

GET /en-US/firefox/addon/8174/ HTTP/1.1
Host: addons.mozilla.org
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fr-FR; rv:1.9.2) Gecko/20100207 Ant.com Toolbar 2.0.1 Namoroka/3.6 XPCOMViewer/0.9.2
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 115
Connection: keep-alive
Cookie: __utma=164683759.491462169.1263204211.1269418856.1269420283.46; __utmz=164683759.1269419595.45.9.utmccn=(organic)|utmcsr=google|utmctr=video+downloadhelper|utmcmd=organic; s_vsn_mozillaaddonsorg_1=7889418390051; __utmv=164683759.Loggedout; dloadday=89.162.161.202.1264093954289258; __unam=f7237fc-12725529045-2afb23ac-1; SSID_AMO=ibg24m015QzC01ALYi0C; __utmb=164683759; __utmc=164683759; X-Mapping-kgbglcod=5ED4FA17FAAD9E52CB266520898172FD; s_cc=true; s_sq=%5B%5BB%5D%5D
Cache-Control: max-age=0

HTTP/1.1 200 OK
Server: Apache
Content-Type: text/html; charset=UTF-8
Date: Wed, 24 Mar 2010 06:18:54 GMT
Keep-Alive: timeout=5, max=997
X-AMO-ServedBy: pm-app-amo17.mozilla.org
Accept-Ranges: bytes
Via: Moz-Cache-zlb02
X-Powered-By: PHP/5.2.9
Content-Length: 605
Connection: Keep-Alive
X-Cache-Info: cached

Comment 6

[Stefan Sitter [:ssitter]]

Attachment: Live HTTP headers output

I have seen this error too using Opera 10.50 and Firefox 3.6.3pre on Windows. Tried to open <https://addons.mozilla.org/de/thunderbird/addon/2313> from a.m.o search result page, got the message "Fehlender Parameter: addon_id" and was redirected to <https://addons.mozilla.org/de/thunderbird/>.

Comment 7

[:Gijs (he/him)]

I can still reproduce this:

https://addons.mozilla.org/en-US/firefox/addon/6665

GET /en-US/firefox/addon/6665 HTTP/1.1
Host: addons.mozilla.org
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 115
Connection: keep-alive
Cookie: dloadday=194.151.176.132.1273476075978769; WT_FPC=id=2622d85d8327e63b3261273440148616:lv=1273526505254:ss=1273526464928; wtspl=548580; amo_home_promo_seen=1

HTTP/1.1 200 OK
Server: Apache
X-Backend-Server: pm-app-amo17
Content-Type: text/html; charset=UTF-8
X-amo-darklaunch: remora
Date: Tue, 11 May 2010 04:08:37 GMT
Keep-Alive: timeout=5, max=994
X-AMO-ServedBy: pm-app-amo17.mozilla.org
Accept-Ranges: bytes
Via: Moz-Cache-ams-zlb01
X-Powered-By: PHP/5.2.9
X-Cache-Info: cached, cached
Content-Length: 605
Connection: Keep-Alive

I'm happy to debug this some more if required (and if it doesn't go away in a few hours or something)... it's a pretty annoying bug, although I can't repro it for all add-ons.