Need huge test case for Function.apply

VERIFIED FIXED in flash10.2.x-Spicy

Status

Tamarin
Virtual Machine
P3
normal
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Tommy Reilly, Assigned: Lars T Hansen)

Tracking

unspecified
flash10.2.x-Spicy
Bug Flags:
flashplayer-qrb +

Details

(Whiteboard: Has patch)

Attachments

(1 attachment, 1 obsolete attachment)

2.73 KB, patch
Tommy Reilly
: review+
Brent Baker
: review+
Details | Diff | Splinter Review
(Reporter)

Description

8 years ago
Bug 551169 was exposed by a very large Function.apply call (ie huge array).  In conjunction with AIR where USE_SYSTEM_MALLOC is defined this results in a large GCRoot being created with system malloc.  Upon free this memory is returned to the system due to the malloc policy of going straight to the OS for alloc requests over a certain size (128k I believe).     Anyways we need a (deep?) test case that makes a huge (multi megabyte) Array and passes it to Function.apply and we it to run in normal builds and a USE_SYSTEM_MALLOC build.

Updated

8 years ago
Flags: flashplayer-qrb?
Priority: -- → P3
Target Milestone: --- → flash10.1.1

Updated

8 years ago
Flags: flashplayer-qrb? → flashplayer-qrb+
(Assignee)

Comment 1

8 years ago
Created attachment 435904 [details]
Sketch for a test case

This needs to be massaged to fit into our testing framework probably, and presumably it could run many iterations to trigger GC etc, but I think it's more or less what's called for.
(Assignee)

Updated

8 years ago
Assignee: nobody → lhansen
(Assignee)

Comment 2

8 years ago
Created attachment 437079 [details] [diff] [review]
Test case

This becomes test/acceptance/ecma3/Function/apply_001.as.
Attachment #435904 - Attachment is obsolete: true
Attachment #437079 - Flags: review?(treilly)
Attachment #437079 - Flags: review?(brbaker)
(Assignee)

Updated

8 years ago
Whiteboard: Has patch

Updated

8 years ago
Attachment #437079 - Flags: review?(brbaker) → review+
(Reporter)

Updated

8 years ago
Attachment #437079 - Flags: review?(treilly) → review+
(Assignee)

Comment 3

8 years ago
tamarin-redux-argo changeset:   3937:240556a76b45
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Status: RESOLVED → VERIFIED

Updated

8 years ago
Target Milestone: flash10.1.1 → flash10.2.x-Spicy
You need to log in before you can comment on or make changes to this bug.