551969 - Broken SSL with sharethis

Status: VERIFIED FIXED

(Websites Graveyard :: getpersonas.com, defect)

Description

[u278084]

Load the above URL, you'll notice that warning about unencrypted data being sent. Looks to be caused by the sharethis javascript code, which is being loaded using http.

Understood if this is WONT FIX according to bug 486371#c7

Comment 1

[Ryan Doherty (:rdoherty)]

We should probably fix this as we do allow viewing the site over ssl. Bug 486371 was about requiring ssl only for getpersonas.com

Comment 2

[Ryan Doherty (:rdoherty)]

Patricio: The site needs to detect if the site is being served by SSL and change the sharethis JS link to https.

You can see example code in server/lib/cdn_config.php

Comment 3

[Patricio Pérez (:janitux)]

Attachment: Proposed Patch

Comment 4

[Reed Loden [:reed]]

Comment on attachment 438010 [details] [diff] [review]
Proposed Patch

sharethis doesn't support SSL, so this won't work...

Should just not display it on SSL-ized pages (or swap to something else like addthis).

Comment 5

[Ryan Doherty (:rdoherty)]

(In reply to comment #4)
> (From update of attachment 438010 [details] [diff] [review])
> sharethis doesn't support SSL, so this won't work...
> 
> Should just not display it on SSL-ized pages (or swap to something else like
> addthis).

Arg, ok. Patricio, please replace the sharethis code with addthis (localize 'Share' and detect ssl):


<div class="addthis_toolbox addthis_default_style">
<a href="http://www.addthis.com/bookmark.php?v=250&amp;username=personas" class="addthis_button_compact">Share</a>
</div>
<script type="text/javascript" src="http://s7.addthis.com/js/250/addthis_widget.js#username=personas"></script>

Comment 6

[Patricio Pérez (:janitux)]

Attachment: Proposed patch with addthis v1

Now using addthis, the text is localized and detects SSL.
I'm still working on the alignment.

Comment 7

[Ryan Doherty (:rdoherty)]

Comment on attachment 438377 [details] [diff] [review]
Proposed patch with addthis v1

Awesome, looks good!

Comment 8

[Patricio Pérez (:janitux)]

fixed on r67338

Comment 9

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.