Broken SSL with sharethis

VERIFIED FIXED in 2.7

Status

Websites Graveyard
getpersonas.com
VERIFIED FIXED
8 years ago
5 years ago

People

(Reporter: cesar, Assigned: janitux)

Tracking

unspecified

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Load the above URL, you'll notice that warning about unencrypted data being sent. Looks to be caused by the sharethis javascript code, which is being loaded using http.

Understood if this is WONT FIX according to bug 486371#c7
We should probably fix this as we do allow viewing the site over ssl. Bug 486371 was about requiring ssl only for getpersonas.com
Target Milestone: --- → 2.6
Target Milestone: 2.6 → 2.7
Patricio: The site needs to detect if the site is being served by SSL and change the sharethis JS link to https.

You can see example code in server/lib/cdn_config.php
Assignee: nobody → janitux
(Assignee)

Comment 3

8 years ago
Created attachment 438010 [details] [diff] [review]
Proposed Patch
Attachment #438010 - Flags: review?(rdoherty)
Attachment #438010 - Flags: review?(rdoherty) → review+
Comment on attachment 438010 [details] [diff] [review]
Proposed Patch

sharethis doesn't support SSL, so this won't work...

Should just not display it on SSL-ized pages (or swap to something else like addthis).
(In reply to comment #4)
> (From update of attachment 438010 [details] [diff] [review])
> sharethis doesn't support SSL, so this won't work...
> 
> Should just not display it on SSL-ized pages (or swap to something else like
> addthis).

Arg, ok. Patricio, please replace the sharethis code with addthis (localize 'Share' and detect ssl):


<div class="addthis_toolbox addthis_default_style">
<a href="http://www.addthis.com/bookmark.php?v=250&amp;username=personas" class="addthis_button_compact">Share</a>
</div>
<script type="text/javascript" src="http://s7.addthis.com/js/250/addthis_widget.js#username=personas"></script>
(Assignee)

Comment 6

8 years ago
Created attachment 438377 [details] [diff] [review]
Proposed patch with addthis v1

Now using addthis, the text is localized and detects SSL.
I'm still working on the alignment.
Attachment #438010 - Attachment is obsolete: true
Attachment #438377 - Flags: review?(rdoherty)
Comment on attachment 438377 [details] [diff] [review]
Proposed patch with addthis v1

Awesome, looks good!
Attachment #438377 - Flags: review?(rdoherty) → review+
(Assignee)

Comment 8

8 years ago
fixed on r67338
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Verified, FIXED.
Status: RESOLVED → VERIFIED
Component: getpersonas.com → getpersonas.com
Product: Websites → Websites Graveyard
You need to log in before you can comment on or make changes to this bug.