551991 - Redirect in search with unicode values crashes

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect)

Description

[Jeff Balogh (:jbalogh)]

I don't think urls are supposed to have unicode, but it looks like we'll have to deal with this.

Traceback (most recent call last):

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/django/core/handlers/base.py", line 101, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/api/views.py", line 191, in redirect_view
   (api.CURRENT_VERSION, url))

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/django/http/__init__.py", line 444, in __init__
   self['Location'] = redirect_to

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/django/http/__init__.py", line 350, in __setitem__
   header, value = self._convert_to_ascii(header, value)

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/django/http/__init__.py", line 339, in _convert_to_ascii
   value = value.encode('us-ascii')

UnicodeEncodeError: 'ascii' codec can't encode characters in position 16-20: ordinal not in range(128), HTTP response headers must be in US-ASCII format

Comment 1

[Wil Clouser [:clouserw]]

-> davedash.  We need this fixed before the API can go live.

Comment 2

[Jeff Balogh (:jbalogh)]

New failure: /he/firefox/api/1.2/search/für

Traceback (most recent call last):

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/django/core/handlers/base.py", line 101, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/api/urls.py", line 9, in <lambda>
   class_view = lambda x: lambda *args, **kwargs: x()(*args, **kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/api/views.py", line 76, in __call__
   return self.process_request(*args, **kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/api/views.py", line 152, in process_request
   query = urllib.unquote(query.encode('ascii'))

UnicodeEncodeError: 'ascii' codec can't encode character u'\xfc' in position 1: ordinal not in range(128)

Comment 3

[Fred Wenzel [:wenzel]]

(In reply to comment #2)
> New failure: /he/firefox/api/1.2/search/für

Oh, somebody wants to sign up for German classes ;)

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Fixed in: http://github.com/jbalogh/zamboni/commit/6bd85c43d93c183e58c20a4cacc02e7537c21acb

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on:

https://preview.addons.mozilla.org/z/he/firefox/api/1.2/search/f%C3%BCr -and-
https://preview.addons.mozilla.org/en-US/firefox/api/search/%E3%83%84%E3%83%BC%E3%83%AB%E3%83%90%E3%83%BC