Closed Bug 5520 Opened 21 years ago Closed 21 years ago

_PR_MD_LSEEK64 tests for the failure of SetFilePointer incorrectly.

Categories

(NSPR :: NSPR, defect, P3)

x86
Windows 95
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

In the Win95 version of _PR_MD_LSEEK64 (w95io.c),
we only check the return value of SetFilePointer
to see if it fails.  That's not sufficient for
a large file.  When the third argument (lpDistanceToMoveHigh)
for SetFilePointer is not NULL, if SetFilePointer
returns 0xFFFFFFFF, we also need to call GetLastError
to find out if SetFilePointer really fails.

The NT version of _PR_MD_LSEEK64 (ntio.c) does this
correctly.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Fixed.  I also rewrote the code for converting between
the 64-bit offset and its two 32-bit components, following
the example in MSDN documentation of SetFilePointer
(http://msdn.microsoft.com/library/sdkdoc/winbase/filesio_8iwi.htm).
/cvsroot/mozilla/nsprpub/pr/src/md/windows/w95io.c, revision 3.8.
NSPR now has its own Bugzilla product.  Moving this bug to the NSPR product.
this fix is not visible to qa. if you think this bug should be reopened,
please do so.

will mark as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.