Closed
Bug 552003
Opened 16 years ago
Closed 16 years ago
Passing an empty mozIStorageBindingParamsArray does not error
Categories
(Core :: SQLite and Embedded Database Bindings, defect, P1)
Core
SQLite and Embedded Database Bindings
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a4
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
3.33 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
Passing an empty mozIStorageBindingParamsArray does not error but puts us in a weird state and asserts. We should check this when we bind it to the statement, and return an error if it is done.
|
Assignee | |
Comment 1•16 years ago
|
||
Simple enough to fix...
|
|
Assignee | |
Comment 2•16 years ago
|
||
Also, asuth, you'll probably want to update your async patch to test and do this too.
Blocks: 536978
Priority: -- → P1
|
||
Updated•16 years ago
|
Attachment #432202 -
Flags: review?(bugmail) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
I'll set the target milestone right when it gets added later today...
http://hg.mozilla.org/mozilla-central/rev/1df18e6b6e78
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
|
|
Assignee | |
Updated•16 years ago
|
Target Milestone: --- → mozilla1.9.3a4
|
|
Assignee | |
Updated•16 years ago
|
Keywords: dev-doc-needed
|
||
Comment 4•16 years ago
|
||
Keywords: dev-doc-needed → dev-doc-complete
|
||
Updated•16 years ago
|
blocking2.0: ? → ---
|
||
Updated•1 year ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•