552011 - Dialog crash fix + Qt widget cleanup

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Dialog fixes, + widget clenaup

We are not handling properly Dialog windows/widgets, we should create QGW if dialog parented with existing window, and make new QGV in case if dialog created without parent widget.

Also this pathc has more simple QGV initialization with helper classes.

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 432192 [details] [diff] [review]
Dialog fixes, + widget clenaup

+        }
+
+        if (aEvent->type() == QEvent::WindowDeactivate) {

else if


+            mTopLevelWidget->setGeometry( 0.0, 0.0,


No space before the first argument


+            QApplication::postEvent(mTopLevelWidget, new QCloseEvent(*aEvent));

Who cleans up this allocation?



In MozQGraphicsViewEvents methods, please check the parameters for null before using them

Comment 2

[Oleg Romashin (:romaxa)]

> Who cleans up this allocation?

Does it help?
http://qt.nokia.com/doc/4.6/qcoreapplication.html#postEvent

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Fixed comment

Comment 4

[Oleg Romashin (:romaxa)]

(In reply to comment #1)
> (From update of attachment 432192 [details] [diff] [review])
> +        }
> +
> +        if (aEvent->type() == QEvent::WindowDeactivate) {
> 
> else if

Nothing, this is handled in MozQGraphicsView::event as QGraphicsView::event

Comment 5

[Oleg Romashin (:romaxa)]

Landed in:
http://hg.mozilla.org/mozilla-central/rev/d89d0bb1a51c