g_type_init required for conic initialization when building with Qt platform

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

1.9.2 Branch
Other
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

GType not initialized in the right moment when we are running conic stuff on Qt port.
Attachment #432194 - Flags: review?(dougt)
Comment on attachment 432194 [details] [diff] [review]
Fix g_type_init for Qt port initialization

why here?  should this go somewhere else?
Unfortunately this  is called from nsMaemoNetworkLinkService::Init, and this is called from component registration...

WARNING: XPCOM objects created/destroyed from static ctor/dtor: 'gActivityTLS != BAD_TLS_INDEX && NS_PTR_TO_INT32(PR_GetThreadPrivate(gActivityTLS)) == 0', file /home/romaxaxz/microbcomponent/mozilla-central/xpcom/base/nsTraceRefcntImpl.cpp, line 974
xulrunner-bin[5012]: GLIB CRITICAL ** GLib-GObject - /home/bifh3/harmattan-i386-unreleased.cs2009q1/work/glib2.0-2.22.4/gobject/gtype.c:2458: initialization assertion failed, use IA__g_type_init() prior to this function
xulrunner-bin[5012]: GLIB CRITICAL ** GLib-GObject - g_object_new: assertion `G_TYPE_IS_OBJECT (object_type)' failed
###!!! ASSERTION: Error when creating connection: 'gConnection', file /home/romaxaxz/microbcomponent/mozilla-central/netwerk/system/maemo/nsMaemoNetworkManager.cpp, line 157
*** Registering components in: xpconnect
*** Registering components in: nsUConvModule
*** Registering components in: nsI18nModule
*** Registering components in: nsChardetModule
I think this should live in:

/toolkit/xre/nsNativeAppSupportUnix.cpp

Right now that file isn't compiled when building Qt and probably is very Gtk specific.  Maybe create a new file for Qt.
ok, I'll check it.
Posted patch Like this?Splinter Review
Assignee: nobody → romaxa
Attachment #432194 - Attachment is obsolete: true
Attachment #432389 - Flags: review?(dougt)
Attachment #432194 - Flags: review?(dougt)
Comment on attachment 432389 [details] [diff] [review]
Like this?

fix the copyright.

nit:

did you consider calling it 
nsNativeAppSupportQt
Attachment #432389 - Flags: review?(dougt) → review+
Pushed
http://hg.mozilla.org/mozilla-central/rev/d9e13024740c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.