Closed Bug 552024 Opened 12 years ago Closed 12 years ago

Initial VKB implementation for Qt port

Categories

(Core Graveyard :: Widget: Qt, defect)

1.9.2 Branch
Other
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: romaxa, Assigned: romaxa)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch VKB patch fix (obsolete) — Splinter Review
We have some patch for Widget Qt implementation based on Maemo6 code.

I would like to push it in upstream, and reduce list of our patches.
Progress still ongoing, but I think we should push this patch.
Attachment #432198 - Flags: review?(dougt)
Comment on attachment 432198 [details] [diff] [review]
VKB patch fix

This required 4.6. 

No need for the extra spaces

+    QWidget* focusWidget = qApp->focusWidget();
+
+    if (focusWidget) {
+
+        QInpu...


in SetIMEEnabled and GetIMEEnabled, i think you need to check mWidget for null.
Attachment #432198 - Flags: review?(dougt) → review-
Attached patch Fixed commentsSplinter Review
Assignee: nobody → romaxa
Attachment #432198 - Attachment is obsolete: true
Attachment #432211 - Flags: review?(dougt)
Attachment #432211 - Flags: review?(dougt) → review+
Pushed in:
http://hg.mozilla.org/mozilla-central/rev/36b0d4c50aa2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.