552158 - People other than Gerv are apparently finding ways to set bugs to EXPIRED

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Dave Miller [:justdave]]

https://bugzilla.mozilla.org/buglist.cgi?type0-1-0=changedafter&query_format=advanced&value0-1-0=6m&field0-1-0=resolution&field0-0-0=resolution&type0-0-0=changedto&value0-0-0=EXPIRED

flagging security-sensitive for now out of fear of it getting abused if it gets advertised too loudly.

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

Something like this?

Note: untested; written at 4am; be warned.

Comment 2

[Dave Miller [:justdave]]

yeah, that'll probably do it.

Patch has been applied to bugzilla-stage-tip

Comment 3

[Reed Loden [:reed]]

kdangoor, please stop using EXPIRED. Thanks! :)

Comment 4

[Dave Miller [:justdave]]

modified Bugzilla/Bug.pm
Committed revision 6760.

Comment 5

[Reed Loden [:reed]]

Attachment: follow-up - v1

"EXPIRED" resolution still shows on edit multiple bugs interface due to a dumb bug. :(

Comment 6

[Reed Loden [:reed]]

Still, the code in Bugzilla/Bug.pm:check_can_change_field() should have prevented KaiRo from using it even if it's listed... Need to figure that out.

Comment 7

[Reed Loden [:reed]]

Attachment: follow-up - v2

Tracked down the problem. :(

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 442186 [details] [diff] [review]
follow-up - v2

I C wut U did thar

Comment 9

[Dave Miller [:justdave]]

modified Bugzilla/Bug.pm
modified template/en/default/list/edit-multiple.html.tmpl
Committed revision 6780.

Comment 10

[Dave Miller [:justdave]]

and pushed to production.