552168 - Displaying bug comments loads users one at a time

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Max Kanat-Alexander]

Right now, when you call $bug->comments and then loop through them and call $comment->user on them (which basically every caller of $bug->comments does), we load the Bugzilla::User object individually for each comment. Currently on a bug with a large number of comments, this is the second-most time we spend in SQL. (0.15 seconds on my machine--not very much, but it's probably more on a loaded machine, and it's a pretty simple thing to fix, actually).

Comment 1

[Max Kanat-Alexander]

Attachment: v1

With this patch applied, the SQL for loading users disappears from the top 10 SQL calls entirely, even for the bug with the most comments on bmo, and it's a pretty simple patch.

Comment 2

[Frédéric Buclin]

Comment on attachment 432316 [details] [diff] [review]
v1

I didn't test it, but it looks good. r=LpSolit

Comment 3

[Frédéric Buclin]

Do you want it for 3.6 too?

Comment 4

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Bug.pm
modified Bugzilla/Comment.pm
Committed revision 7064

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/                         
modified Bugzilla/Bug.pm
modified Bugzilla/Comment.pm
Committed revision 7033.