552284 - Crash [@ gfxDWriteFont::ComputeMetrics] with font-family: DejaVu Sans Mono;font-style: oblique;

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, which crashes current trunk build.

http://crash-stats.mozilla.com/report/index/0b94bfe0-93e4-4b65-ad54-66e882100313
0  	xul.dll  	gfxDWriteFont::ComputeMetrics  	 gfx/thebes/src/gfxDWriteFonts.cpp:110
1 	xul.dll 	gfxDWriteFont::gfxDWriteFont 	gfx/thebes/src/gfxDWriteFonts.cpp:77
2 	xul.dll 	gfxDWriteFontEntry::CreateFontInstance 	gfx/thebes/src/gfxDWriteFontList.cpp:306
3 	xul.dll 	gfxFontEntry::FindOrMakeFont 	gfx/thebes/src/gfxFont.cpp:121
4 	xul.dll 	gfxFontGroup::FindPlatformFont 	gfx/thebes/src/gfxFont.cpp:1500
5 	xul.dll 	gfxFontGroup::FontResolverProc 	gfx/thebes/src/gfxFont.cpp:1729
6 	xul.dll 	gfxWindowsPlatform::ResolveFontName 	gfx/thebes/src/gfxWindowsPlatform.cpp:298
7 	xul.dll 	gfxFontGroup::ForEachFontInternal 	gfx/thebes/src/gfxFont.cpp:1695

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Do not attempt to compute metrics if invalid

This is a regression from http://hg.mozilla.org/mozilla-central/rev/78b8c71b83d9. We should only compute our metrics if we're valid. Otherwise we'll dereference a NULL mFontFace.

Comment 2

[Jonathan Kew [:jfkthame]]

Comment on attachment 432551 [details] [diff] [review]
Do not attempt to compute metrics if invalid

Yes, we definitely need to check that result before proceeding!

Comment 3

[Bas Schouten (:bas.schouten)]

Pushed http://hg.mozilla.org/mozilla-central/rev/ebea05ad4f5b.

Comment 4

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100419 Minefield/3.7a5pre