Closed
Bug 552385
Opened 14 years ago
Closed 14 years ago
"Memory" directory is compiling twice while building fennec
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.3a4
People
(Reporter: starkov.egor, Assigned: starkov.egor)
References
Details
Attachments
(1 file)
1.05 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091214 Firefox/3.5 Build Identifier: When compiling fennec "memory" directory is copied into to build directories "fennec" and xulrunner and compiled also twice. "memory" should be compiled only once in xulrunner and excluded from fennec build. Reproducible: Always Steps to Reproduce: Build mobile according to https://wiki.mozilla.org/Mobile/Build/Fennec Actual Results: "memory" directory not existing and not compiling in mobilebase/fennec Expected Results: "memory" directory exists and compiling in mobilebase/fennec
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #432516 -
Flags: review?(ted.mielczarek)
Comment 2•14 years ago
|
||
Also there are no any reason to compile libmozalloc when we are compiling against LIBXUL_SDK, and because LIBXUL_SDK is providing shared libmozalloc library
Updated•14 years ago
|
Assignee: nobody → starkov.egor
Component: XPCOM → Build Config
QA Contact: xpcom → build-config
Comment 3•14 years ago
|
||
Comment on attachment 432516 [details] [diff] [review] exclude memory from fennec build Ok, makes sense.
Attachment #432516 -
Flags: review?(ted.mielczarek) → review+
Updated•14 years ago
|
Comment 4•14 years ago
|
||
Pushed in: http://hg.mozilla.org/mozilla-central/rev/d46f1771de59
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Keywords: checkin-needed
Updated•14 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a4
Version: unspecified → Trunk
Comment 5•14 years ago
|
||
Comment on attachment 432516 [details] [diff] [review] exclude memory from fennec build >-if [ "$MOZ_MEMORY" ]; then >+if [ "$MOZ_MEMORY" -a "$LIBXUL_SDK" -eq ""]; then Although this works in bash, it's not legal POSIX syntax because you are missing a space before the ].
Comment 6•14 years ago
|
||
(In reply to comment #5) >(From update of attachment 432516 [details] [diff] [review]) >>-if [ "$MOZ_MEMORY" ]; then >>+if [ "$MOZ_MEMORY" -a "$LIBXUL_SDK" -eq ""]; then >Although this works in bash, it's not legal POSIX syntax because you are >missing a space before the ]. This was incidentally fixed by bug 554583.
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•