552385 - "Memory" directory is compiling twice while building fennec

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Egor Starkov]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091214 Firefox/3.5
Build Identifier: 

When compiling fennec "memory" directory is copied into to build directories "fennec" and xulrunner and compiled also twice. "memory" should be compiled only once in xulrunner and excluded from fennec build.

Reproducible: Always

Steps to Reproduce:
Build mobile according to https://wiki.mozilla.org/Mobile/Build/Fennec
Actual Results:  
"memory" directory not existing and not compiling in mobilebase/fennec

Expected Results:  
"memory" directory exists and compiling in mobilebase/fennec

Comment 1

[Egor Starkov]

Attachment: exclude memory from fennec build

Comment 2

[Oleg Romashin (:romaxa)]

Also there are no any reason to compile libmozalloc when we are compiling against LIBXUL_SDK, and because LIBXUL_SDK is providing shared libmozalloc library

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 432516 [details] [diff] [review]
exclude memory from fennec build

Ok, makes sense.

Comment 4

[Oleg Romashin (:romaxa)]

Pushed in:
http://hg.mozilla.org/mozilla-central/rev/d46f1771de59

Comment 5

[[e-mail]]

Comment on attachment 432516 [details] [diff] [review]
exclude memory from fennec build

>-if [ "$MOZ_MEMORY" ]; then
>+if [ "$MOZ_MEMORY" -a "$LIBXUL_SDK" -eq ""]; then
Although this works in bash, it's not legal POSIX syntax because you are missing a space before the ].

Comment 6

[[e-mail]]

(In reply to comment #5)
>(From update of attachment 432516 [details] [diff] [review])
>>-if [ "$MOZ_MEMORY" ]; then
>>+if [ "$MOZ_MEMORY" -a "$LIBXUL_SDK" -eq ""]; then
>Although this works in bash, it's not legal POSIX syntax because you are
>missing a space before the ].
This was incidentally fixed by bug 554583.