Closed Bug 552385 Opened 13 years ago Closed 13 years ago
"Memory" directory is compiling twice while building fennec
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091214 Firefox/3.5 Build Identifier: When compiling fennec "memory" directory is copied into to build directories "fennec" and xulrunner and compiled also twice. "memory" should be compiled only once in xulrunner and excluded from fennec build. Reproducible: Always Steps to Reproduce: Build mobile according to https://wiki.mozilla.org/Mobile/Build/Fennec Actual Results: "memory" directory not existing and not compiling in mobilebase/fennec Expected Results: "memory" directory exists and compiling in mobilebase/fennec
Also there are no any reason to compile libmozalloc when we are compiling against LIBXUL_SDK, and because LIBXUL_SDK is providing shared libmozalloc library
Assignee: nobody → starkov.egor
Component: XPCOM → Build Config
QA Contact: xpcom → build-config
Comment on attachment 432516 [details] [diff] [review] exclude memory from fennec build Ok, makes sense.
Attachment #432516 - Flags: review?(ted.mielczarek) → review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
Version: unspecified → Trunk
Comment on attachment 432516 [details] [diff] [review] exclude memory from fennec build >-if [ "$MOZ_MEMORY" ]; then >+if [ "$MOZ_MEMORY" -a "$LIBXUL_SDK" -eq ""]; then Although this works in bash, it's not legal POSIX syntax because you are missing a space before the ].
(In reply to comment #5) >(From update of attachment 432516 [details] [diff] [review]) >>-if [ "$MOZ_MEMORY" ]; then >>+if [ "$MOZ_MEMORY" -a "$LIBXUL_SDK" -eq ""]; then >Although this works in bash, it's not legal POSIX syntax because you are >missing a space before the ]. This was incidentally fixed by bug 554583.
You need to log in before you can comment on or make changes to this bug.