nsWindow.cpp doesn't compile when Q_WS_X11 is defined

RESOLVED FIXED

Status

Core Graveyard
Widget: Qt
RESOLVED FIXED
8 years ago
a year ago

People

(Reporter: MikeK, Assigned: MikeK)

Tracking

Trunk
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
/home/mike/MozillaCode/qt/100315/mozilla-central/widget/src/qt/nsWindow.cpp: In member function ‘virtual void* nsWindow::GetNativeData(PRUint32)’:
/home/mike/MozillaCode/qt/100315/mozilla-central/widget/src/qt/nsWindow.cpp:776: error: jump to case label
/home/mike/MozillaCode/qt/100315/mozilla-central/widget/src/qt/nsWindow.cpp:771: error:   crosses initialization of ‘QWidget* widget’
/home/mike/MozillaCode/qt/100315/mozilla-central/widget/src/qt/nsWindow.cpp:782: error: jump to case label
/home/mike/MozillaCode/qt/100315/mozilla-central/widget/src/qt/nsWindow.cpp:771: error:   crosses initialization of ‘QWidget* widget’
/home/mike/MozillaCode/qt/100315/mozilla-central/widget/src/qt/nsWindow.cpp:785: error: jump to case label
/home/mike/MozillaCode/qt/100315/mozilla-central/widget/src/qt/nsWindow.cpp:771: error:   crosses initialization of ‘QWidget* widget’
make[7]: *** [nsWindow.o] Error 1

This is due to a missing set of {} to control the scope of the QWidget* widget local variable
(Assignee)

Comment 1

8 years ago
Created attachment 432536 [details]
Fix

Note that this might not be the only problem on trunk
Assignee: nobody → mkristoffersen
Status: NEW → ASSIGNED
(Assignee)

Comment 2

8 years ago
Created attachment 432537 [details] [diff] [review]
Woups wrong file, this should be the right one
Attachment #432536 - Attachment is obsolete: true
Attachment #432537 - Flags: review?(romaxa)
(Assignee)

Updated

8 years ago
Attachment #432536 - Attachment is patch: false

Comment 3

8 years ago
Very good.  You beat me to this one! :oD
Comment on attachment 432537 [details] [diff] [review]
Woups wrong file, this should be the right one

Oh, sorry about this bustage.
Attachment #432537 - Flags: review?(romaxa) → review+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Pushed in:
http://hg.mozilla.org/mozilla-central/rev/740f467c8b6c
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.