Closed
Bug 552578
Opened 15 years ago
Closed 15 years ago
Frame queue wait logic spins unnecessarily while waiting for new frames
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | ? |
People
(Reporter: kinetik, Assigned: kinetik)
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
The logic that waits for the frame queue to fill (http://mxr.mozilla.org/mozilla-central/source/content/media/ogg/nsOggDecoder.cpp#1549) waits for 1/2 the callback period. This causes us to waste CPU in some cases, and also causes playback problems for very high framerate videos (e.g. http://myrandomnode.dyndns.org:8080/~gmaxwell/cortest/dupes.ogv). As far as I can tell the timeout is unnecessary and the wait can be indefinite because any state changes being waited on will signal the monitor.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: nobody → kinetik
Attachment #432707 -
Flags: review?(chris.double)
|
||
Updated•15 years ago
|
Attachment #432707 -
Attachment is patch: true
Attachment #432707 -
Attachment mime type: application/octet-stream → text/plain
Attachment #432707 -
Flags: review?(chris.double) → review+
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs landing]
|
|
Assignee | |
Updated•15 years ago
|
status1.9.2:
--- → ?
|
|
Assignee | |
Comment 2•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•