552636 - View source after form submit shows initial form page instead of new page (again)

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Stappel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a3pre) Gecko/20100315 Minefield/3.7a3pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a3pre) Gecko/20100315 Minefield/3.7a3pre (.NET CLR 3.5.30729)

It looks like bug #469302 is back.
A view source action shows the content of before the post action and not the result.

Bug 469302 has also a URL to test it against.

Reproducible: Always

Steps to Reproduce:
1. go to http://www.stappel.com/test.php
2. press submit button
3. screen shows: Request type: POST
4. do a view page source. it shows: Request type: GET
Actual Results:  
GET

Expected Results:  
the POST result

It most certainly regression. 

Server logs it Does a new GET on the view source.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

confirmed: works on 1.9.2 branch, failes on trunk.
as Bug 469302 blocked, this should too.

Comment 2

[Stappel]

Works: 
Build 20100224060607
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a2pre) Gecko/20100224 Minefield/3.7a2pre (.NET CLR 3.5.30729)
http://hg.mozilla.org/mozilla-central/rev/ddfecbc93934

FAIL:
Build 20100225035447
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a2pre) Gecko/20100225 Minefield/3.7a2pre (.NET CLR 3.5.30729)
http://hg.mozilla.org/mozilla-central/rev/a29d44f196a6

Comment 3

[(mostly gone) XtC4UaLL [:xtc4uall]]

thanks for hunting for the range http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ddfecbc93934&tochange=a29d44f196a6

presumably caused by Bug 546528, no?

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Ugh, I have no idea how this happened, but it does indeed sound like it's my fault :(

Comment 5

[Saint Wesonga]

Attachment: Patch

This seems to fix the problem for me. It seems arg is now a function ("[object XPCNativeWrapper [xpconnect wrapped nsISupports]]")?

Comment 6

[Josh Matthews [:jdm]]

Sounds like bug 553407 is at fault, so the patch is actually working around a recent bug.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 433500 [details] [diff] [review]
Patch

Indeed!

Comment 8

[Saint Wesonga]

Is it possible to write a mochitest for this view source behavior? (It's something I would like to attempt if someone informs me that it _is_ possible).

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Should be possible. I think this tests some viewsource functionality:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/viewsource/test/test_428653.xul

Comment 10

[Stappel]

As bug #553407 is fixed in mozilla-central, this is no longer a problem.
For me the bug can be set to resolved, but maybe someone wants it open for a testcase.