nsMsgSearchOp and nsMsgSearchScope should get new iids

RESOLVED FIXED in Thunderbird 3.1b2

Status

Thunderbird
General
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: palo misik, Assigned: palo misik)

Tracking

unspecified
Thunderbird 3.1b2

Thunderbird Tracking Flags

(thunderbird3.1 beta2-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729)
Build Identifier: 

This is not too critical but it would good to have a simple way to differences these interfaces.
This had to be done in tb30 because this change was made in tb2->tb3. Because interfaces of  tb30 are frozen it would be good to fix it in tb31.

interface nsMsgSearchOp has new and changed constants:
new:
const nsMsgSearchOpValue IsntEmpty = 18; /* primarily for tags */
    const nsMsgSearchOpValue Matches = 19; /* generic term for use by custom terms */
    const nsMsgSearchOpValue DoesntMatch = 20; /* generic term for use by custom terms */

changed:
tb2: const nsMsgSearchOpValue kNumMsgSearchOperators  = 18;     /* must be last operator */
tb3: const nsMsgSearchOpValue kNumMsgSearchOperators  = 21;     /* must be last operator 


interface nsMsgSearchScope has new constants
new:
   /// IMAP and NEWS, searched using local headers
   const nsMsgSearchScopeValue onlineManual = 13;
  /// local news + junk
  const nsMsgSearchScopeValue localNewsJunk = 14;
  /// local news + body
  const nsMsgSearchScopeValue localNewsBody = 15;
  /// local news + junk + body
  const nsMsgSearchScopeValue localNewsJunkBody = 16;


Reproducible: Always
(Assignee)

Comment 1

8 years ago
Created attachment 432768 [details] [diff] [review]
Proposed patch for nsMsgSearchCore.idl
(In reply to comment #1)
> Created an attachment (id=432768) [details]
> Proposed patch for nsMsgSearchCore.idl

Palo can you set the review and super-review request flags ?
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 3

8 years ago
Yes, I can.
Sorry, I forgot.
(Assignee)

Updated

8 years ago
Attachment #432768 - Flags: superreview?(bienvenu)
Attachment #432768 - Flags: review?(bugzilla)

Updated

8 years ago
Attachment #432768 - Flags: superreview?(bienvenu) → superreview+
Attachment #432768 - Flags: review?(bugzilla) → review+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/d3c4e6db7d87
Assignee: nobody → pjemen
Status: NEW → RESOLVED
Last Resolved: 8 years ago
status-thunderbird3.1: --- → beta2-fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
You need to log in before you can comment on or make changes to this bug.