Fix AssertionError in ispdb nightly report.

RESOLVED FIXED

Status

Webtools
ISPDB Server
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: bwinton, Assigned: bwinton)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

8 years ago
Created attachment 432818 [details] [diff] [review]
A patch that converts the assertion into an error message.

The last couple of days of ispdb logs have looked like:
1 38658
2 13832
3 6400
4 3307
5 1878
6 1093
7 660
8 431
9 248
10 and more: 719
Traceback (most recent call last):
  File "tools/quickparse.py", line 59, in <module>
    assert total_queries == sum([d['count'] for d in domains])
AssertionError

This patch changes that assertion into an error.
Attachment #432818 - Flags: review?(gozer)
(Assignee)

Comment 1

8 years ago
Created attachment 432845 [details] [diff] [review]
A patch which reports the actual error.

Turns out it was the entry:
{'count': 2, 'domain': 'adam-handel.de', 'code': '503'}
in the dict that was throwing us off.

So now we report:
1 38658
2 13832
3 6400
4 3307
5 1878
6 1093
7 660
8 431
9 248
10 and more: 719
HITS: 198 domains, accounting for 40235 successes, or 29.8% success rate
MISSES: 33015 domains, accounting for 92030 failures, or 68.1% fail rate
PENDING: 3 domains, accounting for 2942 failures, or 2.2% fail rate
WEIRDOS: 1 domains, accounting for 2 oddities, or 0.0% strangeness rate
  2 counts of adam-handel.de returned 503
Top 20 misses:
  alice.it (868 hits, aka 0.6%)
  libero.it (731 hits, aka 0.5%)
  wp.pl (680 hits, aka 0.5%)
[snip…]

Thanks,
Blake.
Assignee: nobody → bwinton
Attachment #432818 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #432845 - Flags: review?
Attachment #432818 - Flags: review?(gozer)
(Assignee)

Updated

8 years ago
Attachment #432845 - Flags: review? → review?(gozer)
(Assignee)

Comment 2

8 years ago
Created attachment 432856 [details] [diff] [review]
A patch that splits the domains out by response code.

Okay, okay, this is the last patch for today.

The output now is:
1 38658
2 13832
3 6400
4 3307
5 1878
6 1093
7 660
8 431
9 248
10 and more: 719
HITS: 40235 domains, accounting for 40235 successes, or 29.8% success rate
MISSES: 92028 domains, accounting for 92028 failures, or 68.1% fail rate
PENDING: 2942 domains, accounting for 2942 failures, or 2.2% fail rate
WEIRDOS: 4 domains, accounting for 4 oddities, or 0.0% strangeness rate
  bs-tg.de (1 hits, returned 503)
  alice.it (1 hits, returned 503)
  adam-handel.de (1 hits, returned 503)
  kabelmail.de (1 hits, returned 503)
Top 20 misses:
  hasu.jp (1 hits, aka 0.0%)
  laris-meble.nazwa.pl (1 hits, aka 0.0%)
  sagio.me (1 hits, aka 0.0%)
[snip…]
Attachment #432845 - Attachment is obsolete: true
Attachment #432856 - Flags: review?(gozer)
Attachment #432845 - Flags: review?(gozer)
Attachment #432856 - Flags: review?(gozer) → review+
(Assignee)

Comment 3

8 years ago
Checked in as http://viewvc.svn.mozilla.org/vc?view=revision&revision=64232
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

8 years ago
Created attachment 433055 [details] [diff] [review]
A patch to make not everything have a count of 1.

Doh!

Feel free to just commit this if it gets an r+ from you.

Thanks,
Blake.
Attachment #433055 - Flags: review?(gozer)
(Assignee)

Updated

8 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #433055 - Flags: review?(gozer) → review+
(Assignee)

Comment 5

8 years ago
Checked in as http://viewvc.svn.mozilla.org/vc?view=revision&revision=64268
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Component: ispdb → ISPDB Server
Product: Mozilla Messaging → Webtools
You need to log in before you can comment on or make changes to this bug.