55268 - Crash "segment violation" when using PR_FormatTime

Status: VERIFIED FIXED

(NSPR :: NSPR, defect, P2)

Description

[Yannick Koehler]

Included is a fix for this crash.  The BeOS crash because the tm_zone and the tm_gmtoff 
member exist under BeOS but weren't initialized properly.

Comment 1

[Yannick Koehler]

Can't upload with Net+... so here's the patch

Index: prtime.c
===================================================================
RCS file: /cvsroot/mozilla/nsprpub/pr/src/misc/prtime.c,v
retrieving revision 3.9
diff -u -r3.9 prtime.c
--- prtime.c    1999/04/21 21:39:44     3.9
+++ prtime.c    2000/10/05 02:52:29
@@ -1655,6 +1655,13 @@
         return 0;
     }
 #endif
+#ifdef XP_BEOS
+       if(mktime(&a) == -1)
+       {
+      a.tm_zone = 0;
+         a.tm_gmtoff = NULL;
+       }
+#endif

     return strftime(buf, buflen, fmt, &a);
 }

Comment 2

[Yannick Koehler]

This make mozilla crash as soon as you browse therefore I've raised the priority

Comment 3

[Wan-Teh Chang]

Does this patch work?

Index: mozilla/nsprpub/pr/src/misc/prtime.c
===================================================================
RCS file: /cvsroot/mozilla/nsprpub/pr/src/misc/prtime.c,v
retrieving revision 3.9
diff -u -r3.9 prtime.c
--- prtime.c	1999/04/21 21:39:44	3.9
+++ prtime.c	2000/10/05 03:17:49
@@ -1649,7 +1649,7 @@
  * values for these two fields.
  */
 
-#if defined(SUNOS4) || (__GLIBC__ >= 2)
+#if defined(SUNOS4) || (__GLIBC__ >= 2) || defined(XP_BEOS)
     if (mktime(&a) == -1) {
         PR_snprintf(buf, buflen, "can't get timezone");
         return 0;

Comment 4

[Wan-Teh Chang]

Assigned the bug to larryh.

Comment 5

[Yannick Koehler]

Attachment: Same as in the text, but got the change to upload it!

Comment 6

[Yannick Koehler]

Ok tried the propose solution to simply add || defined(XP_BEOS) and it works also!

Comment 7

[Wan-Teh Chang]

Do you want this fix in NSPRPUB_CLIENT_BRANCH?
Any other branches?

Comment 8

[Yannick Koehler]

tip + the client branch.

Btw, when is the client.mk will start using the tip?

Comment 9

[larryh (gone)]

Checking in Wan-Teh's version of patch to the tip of tree.

/cvsroot/mozilla/nsprpub/pr/src/misc/prtime.c,v  <--  prtime.c
new revision: 3.12; previous revision: 3.11

Comment 10

[Wan-Teh Chang]

I checked in the patch on the NSPRPUB_CLIENT_BRANCH
and the NSPRPUB_RELEASE_4_0_BRANCH.

Comment 11

[Kai Lahmann (is there, where MNG is)]

v