Closed Bug 552712 Opened 14 years ago Closed 14 years ago

Remove some NS_DEFINE_CLASSINFO_DATA_WITH_NAME use

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a4

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
NS_DEFINE_CLASSINFO_DATA_WITH_NAME should be avoided, it makes the DOM prototypes and constructors for those classes confusing (eg. there are really multiple constructors for the same name). We currently use NS_DEFINE_CLASSINFO_DATA_WITH_NAME for HTMLCollection, because the HTMLFormControlCollection has an additional interface. Turns out that we don't use that interface anymore (since fixing bug 461560), so we can merge the HTMLCollections. There are two remaining uses of NS_DEFINE_CLASSINFO_DATA_WITH_NAME (MathMLElement and ContentList), but those aren't easy to remove.
Attachment #432858 - Flags: review?(jst)
Attachment #432858 - Flags: superreview+
Attachment #432858 - Flags: review?(jst)
Attachment #432858 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/d2b87aa17dd1
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: