Closed
Bug 552847
Opened 14 years ago
Closed 14 years ago
xpcshell: check-one tests fail to start
Categories
(Testing :: XPCShell Harness, defect)
Testing
XPCShell Harness
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.3a4
People
(Reporter: jdm, Assigned: jdm)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.83 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
The recent changes from bug 493748 broken check-one testing. The attached patch fixes some references to shadowed variables that were missing self prefixes.
|
Assignee | |
Updated•14 years ago
|
Attachment #432957 -
Attachment is patch: true
Attachment #432957 -
Attachment mime type: application/octet-stream → text/plain
|
|
Assignee | |
Updated•14 years ago
|
Attachment #432957 -
Flags: review?(ted.mielczarek)
|
||
Comment 1•14 years ago
|
||
These changes may already be addressed by Serge's patch in bug 493748, by the way. Fortunately ted is on the hook for both reviews, so I guess he'll sort things out.
|
|
Assignee | |
Comment 2•14 years ago
|
||
Yeah, it looks like they're all included in his changes. This patch applies to e10s without any conflicts, though.
|
||
Updated•14 years ago
|
Keywords: regression
|
||
Updated•14 years ago
|
|
||
Comment 4•14 years ago
|
||
I'm guessing the "right" way to fix is for mozilla-central to take serge's patch for bug 493748, then have that slurped into the e10s branch via a merge. That said, this is breaking debugging (make check-interactive is also busted), so perhaps we ought to move on it sooner. I'm cc-ing bsmedberg, who knows more about how we do merges.
|
||
Comment 5•14 years ago
|
||
It's broken on m-c too, so we should take the patch there.
|
|
||
Comment 6•14 years ago
|
||
Ftr, Josh's patch here should fix the --test-path regression. My patch there fixes additional code nits (only).
|
|
||
Updated•14 years ago
|
Attachment #432957 -
Flags: review?(ted.mielczarek) → review+
|
|
||
Comment 7•14 years ago
|
||
Checked into m-c: 5723b43063b6. Thanks Josh! Will land in e10s as soon as I merge from m-c, today.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Flags: in-testsuite-
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.3a4
You need to log in
before you can comment on or make changes to this bug.
Description
•