552871 - xpcshell: ipc tests fail with |_HEAD_JS_PATH is not defined|

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Josh Matthews [:jdm]]

Attachment: Reinstate missing variables

The big reorganization in bug 493748 caused ipc tests to start failing because of some variables and a command-line param that got lost in the merge shuffle of changeset d04db5a2a30a.  That attached patch fixes them again.

Comment 1

[Jason Duell]

Comment on attachment 432983 [details] [diff] [review]
Reinstate missing variables

>   def buildXpcsCmd(self, testdir):
>     """
>       Load the root head.js file as the first file in our test path, before other head, test, and tail files.
>       On a remote system, we overload this to add additional command line arguments, so this gets overloaded.
>     """

Add here:
+     # - NOTE: if you rename/add any of the constants set here, update
+     #   do_load_child_test_harness() in head.js

>     self.xpcsCmd = [self.xpcshell, '-g', self.xrePath, '-j', '-s'] + \
>         ['-e', 'const _HTTPD_JS_PATH = "%s";' % self.httpdJSPath,
>+         '-e', 'const _HEAD_JS_PATH = "%s";' % self.headJSPath,
>         '-f', os.path.join(self.testharnessdir, 'head.js')]


With that comment fix, this is the exact same patch that we initially used to get e10s xpcshell working.   We should check into e10s branch ASAP.

Comment 2

[Josh Matthews [:jdm]]

Attachment: Patch + comments

Comments added.  jduell, would you mind landing this for me?

Comment 3

[Jason Duell]

http://hg.mozilla.org/projects/electrolysis/rev/f65ca93ad682