Closed Bug 552871 Opened 13 years ago Closed 13 years ago

xpcshell: ipc tests fail with |_HEAD_JS_PATH is not defined|

Categories

(Testing :: XPCShell Harness, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jdm, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Reinstate missing variables (obsolete) — Splinter Review
The big reorganization in bug 493748 caused ipc tests to start failing because of some variables and a command-line param that got lost in the merge shuffle of changeset d04db5a2a30a.  That attached patch fixes them again.
Attachment #432983 - Attachment is patch: true
Attachment #432983 - Attachment mime type: application/octet-stream → text/plain
Attachment #432983 - Flags: review?(ted.mielczarek)
Comment on attachment 432983 [details] [diff] [review]
Reinstate missing variables

>   def buildXpcsCmd(self, testdir):
>     """
>       Load the root head.js file as the first file in our test path, before other head, test, and tail files.
>       On a remote system, we overload this to add additional command line arguments, so this gets overloaded.
>     """

Add here:
+     # - NOTE: if you rename/add any of the constants set here, update
+     #   do_load_child_test_harness() in head.js

>     self.xpcsCmd = [self.xpcshell, '-g', self.xrePath, '-j', '-s'] + \
>         ['-e', 'const _HTTPD_JS_PATH = "%s";' % self.httpdJSPath,
>+         '-e', 'const _HEAD_JS_PATH = "%s";' % self.headJSPath,
>         '-f', os.path.join(self.testharnessdir, 'head.js')]


With that comment fix, this is the exact same patch that we initially used to get e10s xpcshell working.   We should check into e10s branch ASAP.
Attachment #432983 - Flags: review?(ted.mielczarek) → review+
Attached patch Patch + commentsSplinter Review
Comments added.  jduell, would you mind landing this for me?
Assignee: nobody → josh
Attachment #432983 - Attachment is obsolete: true
http://hg.mozilla.org/projects/electrolysis/rev/f65ca93ad682
Assignee: josh → nobody
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.