552999 - PointerType.prototype.isNull

Status: RESOLVED FIXED

(Core :: js-ctypes, defect, P1)

Description

[Jason Orendorff [:jorendorff]]

<jorendorff> dwitte: what's the easiest way to find out if the value of
    a pointer CData object is null?
<dwitte> ctypes.cast(obj, ctypes.uintptr_t).value.toString() == "0"
<dwitte> we should probably do .isNull() :)

Comment 1

[[e-mail]]

P1, need this for 1.9.3. Trivial API addition and should be quite useful for devs.

Comment 2

[Josh Matthews [:jdm]]

Attachment: isNull implementation + tests

Here you go.

Comment 3

[[e-mail]]

Comment on attachment 435453 [details] [diff] [review]
isNull implementation + tests

Looks good, but I think we want isNull() to be a function, not a property.

You'll need to add an sPointerInstanceFunctions, and then add that to the appropriate bits through the code. Should be trivial.

(Don't forget to add isNull() to the type ctor tests at http://mxr.mozilla.org/mozilla-central/source/js/ctypes/tests/unit/test_jsctypes.js.in#1570.)

Comment 4

[Josh Matthews [:jdm]]

Attachment: isNull implementation + tests v1.1

All comments addressed.

Comment 5

[[e-mail]]

Comment on attachment 435500 [details] [diff] [review]
isNull implementation + tests v1.1

Cool beans!

Comment 6

[[e-mail]]

In my queue for checkin.

Comment 7

[[e-mail]]

Comment on attachment 435500 [details] [diff] [review]
isNull implementation + tests v1.1

http://hg.mozilla.org/mozilla-central/rev/8c0fdd9ca7dd