553036 - Make nvprof macros non-variadic and cross-platform

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect, P3)

Description

[Lars T Hansen]

Symbian tool chain does not grok variadic macros; let's avoid them.

Comment 1

[Lars T Hansen]

These are the other cross-platform variadic macros in Tamarin:

In CodegenLIR.h:
  DEBUGGER_ONLY

In nanojit.h
  IF_64BIT
  UNLESS_64BIT
  __NanoAssertMsgf
  _NanoAssertMsgf
  NanoAssertMsgf
  verbose_only

In Native.h:
  IF_PEDANTIC
  UNLESS_PEDANTIC
  asm_output

Comment 2

[Lars T Hansen]

Attachment: Patch from Ed for nvprof fixes

Comment 3

[Lars T Hansen]

Attachment: Make the portable _nvprof macro apply to Symbian as well

Comment 4

[Lars T Hansen]

nvprof fixes pushed to tamarin-redux-argo: changeset:   3835:6a3ddcd4a161

Comment 5

[Lars T Hansen]

Closing until such a time as it turns out that the other macros cause trouble for the Symbian tool chain.

Comment 6

[Rick Reitmaier]

nanojit avoided variadic a while back, but it was decided during the nj-merge that this was overly restrictive.

What I'm getting at is that if we convert all the uses, we'll have to monitor it closely on the nanojit front.  nj-central currently does not have any triggers to catch an injection.

Comment 7

[Lars T Hansen]

(In reply to comment #6)
> nanojit avoided variadic a while back, but it was decided during the nj-merge
> that this was overly restrictive.
> 
> What I'm getting at is that if we convert all the uses, we'll have to monitor
> it closely on the nanojit front.  nj-central currently does not have any
> triggers to catch an injection.

OK.  Grepping for __VA_ARGS__ seems to be a good indicator of presence / absence.  Samuli says the Symbian tool chain may see an upgrade soon and the problem may go away.