1.04 KB, text/plain
1.24 KB, application/vnd.mozilla.xul+xml
2.15 KB, patch
|Details | Diff | Splinter Review|
93 bytes, text/html
F-keys (F1-F12) doesn't bubble properly on html select elements, as compared to normal html or xul elements. Verified on "Mozilla/5.0 (X11; U; Linux 2.2.14-5.0 i686; en-US; m18) Gecko/20001002" And a nightly from 2000-09-15.
Is this broken only on Linux or is it broken across all Platform/OS?
Reporter is this still a problem in the latest nightlies?
firstname.lastname@example.org - could you please update the instructions for this test case (assuming the bug still exists) in light of the jar-ification of chrome? Gerv
I tried the testcase and nothing was dumped. But, what is really supposed to happen? Reporter could you tell us what exactly should happen? The visual effects I mean. Thank you, Fabian.
Marking INVALID due to lack of response. Reopen if this is still a problem.
Whoops didnt change it..Marking invalid again..sorry for the spam
Verified on linux with latest nightly (2000-12-15). (See the xul file for installation details.) Fabian: When pressing the two different elements one xul:button and one html:select and thus focusing them, and then pressing F-keys (F1-F12) Mozilla should print out (in the console) what key was pressed. (As defined in the keyset). I'm downloading a Mozilla nightly for windows now and will post the results later. (Sorry for being such a lazy bum ;)
Verified on Windows 2000 with latest nightly. Remember that only F3 and F12 is mapped in the keyset, so you only get output for those in the console.
Marking NEW as per comments.
Now I've gone through nsListControlFrame.cpp and I've seen the problem. Apparently we patch away *all* bubbling not caring whether we actually handle the incoming key-event or not. However, letting all events bubble produce seems bad as well, so my suggestion is to let all key-events we don't handle bubble up. If anyone wants, I could make a patch for this.
Sure, make the patch. All help is welcome.
Created attachment 25456 [details] [diff] [review] Patch to let all key events we didn't handle bubble up.
I have some other patches sitting in my tree and I am going to try to get this in soon.
QA Contact Update
I tested this, and keypress events dont bubble through selects, not only the function keys.
oh, and this was happening on windows 98, marking OS all
moving to 0.9.6
*** Bug 103852 has been marked as a duplicate of this bug. ***
Moving to Future
Created attachment 135463 [details] Testcase This exercises the code this bug was patching (ListControlFrame).
And if that patch fixed this bug, it worksforme (note that code inspection shows that the PreventBubble call in question has been long removed).