55305 - [FIX][MF]keypress events doesn't bubble on html select elements

Status: RESOLVED WORKSFORME

(Core :: Layout: Form Controls, defect)

Description

[Martin Enlund]

F-keys (F1-F12) doesn't bubble properly on html select elements, as compared to
normal html or xul elements.

Verified on 
"Mozilla/5.0 (X11; U; Linux 2.2.14-5.0 i686; en-US; m18) Gecko/20001002"
And a nightly from 2000-09-15.

Comment 1

[Martin Enlund]

Attachment: XUL test case with keyset. (For installation, read inside)

Comment 2

[Kathleen :Brade]

Is this broken only on Linux or is it broken across all Platform/OS?

Comment 3

[Keyser Sose]

Reporter is this still a problem in the latest nightlies?

Comment 4

[Gervase Markham [:gerv]]

[e-mail] - could you please update the instructions for this test 
case (assuming the bug still exists) in light of the jar-ification of chrome?

Gerv

Comment 5

[Fabian Guisset]

I tried the testcase and nothing was dumped. But, what is really supposed to
happen? Reporter could you tell us what exactly should happen? The visual
effects I mean.
Thank you,
Fabian.

Comment 6

[Keyser Sose]

Marking INVALID due to lack of response. Reopen if this is still a problem.

Comment 7

[Keyser Sose]

Whoops didnt change it..Marking invalid again..sorry for the spam

Comment 8

[Martin Enlund]

Attachment: Updated test-case

Comment 9

[Martin Enlund]

Verified on linux with latest nightly (2000-12-15). 
(See the xul file for installation details.)
 
Fabian: When pressing the two different elements one xul:button and one
html:select and thus focusing them, and then pressing F-keys (F1-F12) Mozilla
should print out (in the console) what key was pressed. (As defined in the
keyset).

I'm downloading a Mozilla nightly for windows now and will post the results
later.

(Sorry for being such a lazy bum ;)

Comment 10

[Martin Enlund]

Verified on Windows 2000 with latest nightly. 
Remember that only F3 and F12 is mapped in the keyset, so you only get output
for those in the console.

Comment 11

[Keyser Sose]

Marking NEW as per comments.

Comment 12

[Martin Enlund]

Now I've gone through nsListControlFrame.cpp and I've seen the problem.
Apparently we patch away *all* bubbling not caring whether we actually handle
the incoming key-event or not.
However, letting all events bubble produce seems bad as well, so my suggestion
is to let all key-events we don't handle bubble up.
If anyone wants, I could make a patch for this.

Comment 13

[rods (gone)]

Sure, make the patch. All help is welcome.

Comment 14

[Martin Enlund]

Attachment: Patch to let all key events we didn't handle bubble up.

Comment 15

[rods (gone)]

I have some other patches sitting in my tree and I am going to try to get this 
in soon.

Comment 16

[Vladimir Ermakov]

QA Contact Update

Comment 17

[Vladimir Ermakov]

I tested this, and keypress events dont bubble through selects, not only the
function keys.

Comment 18

[Vladimir Ermakov]

oh, and this was happening on windows 98, marking OS all

Comment 19

[rods (gone)]

moving to 0.9.6

Comment 20

[Alfonso Martinez]

*** Bug 103852 has been marked as a duplicate of this bug. ***

Comment 21

[rods (gone)]

Moving to Future

Comment 22

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

This exercises the code this bug was patching (ListControlFrame).

Comment 23

[Boris Zbarsky [:bzbarsky]]

And if that patch fixed this bug, it worksforme (note that code inspection shows
that the PreventBubble call in question has been long removed).