553094 - Support extension metadata in prefs

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dave, can you please give a bit more details on that bug?

Comment 2

[Dave Townsend [:mossop]]

See https://developer.mozilla.org/en/Localizing_extension_descriptions#Localizing_before_Gecko_1.9

Comment 3

[Dave Townsend [:mossop]]

Fixed: http://hg.mozilla.org/projects/addonsmgr/rev/178dec446ceb

Comment 4

[Dave Townsend [:mossop]]

Also the follow-up fix http://hg.mozilla.org/projects/addonsmgr/rev/e191e8d803fc

Comment 5

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Adds the proepr localization handling and tests.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 435786 [details] [diff] [review]
patch rev 1

>diff --git a/toolkit/mozapps/extensions/XPIProvider.jsm b/toolkit/mozapps/extensions/XPIProvider.jsm
>--- a/toolkit/mozapps/extensions/XPIProvider.jsm
>+++ b/toolkit/mozapps/extensions/XPIProvider.jsm
>@@ -62,6 +62,7 @@ const PREF_EM_CHECK_COMPATIBILITY     = 
> const PREF_EM_CHECK_UPDATE_SECURITY   = "extensions.checkUpdateSecurity";
> const PREF_EM_UPDATE_URL              = "extensions.update.url";
> const PREF_EM_ENABLED_ITEMS           = "extensions.enabledItems";
>+const PREF_EM_EXTENSION_FORMAT        = "extensions.%ID%.";
> const PREF_XPI_ENABLED                = "xpinstall.enabled";
> const PREF_XPI_WHITELIST_REQUIRED     = "xpinstall.whitelist.required";
> 
>@@ -3961,11 +3962,43 @@ function AddonWrapper(addon) {
>   });
> 
>   PROP_LOCALE_SINGLE.forEach(function(prop) {
>-    this.__defineGetter__(prop, function() addon.selectedLocale[prop]);
>+    this.__defineGetter__(prop, function() {
>+      if (addon.active) {
>+        try {
>+          let pref = PREF_EM_EXTENSION_FORMAT.replace(/%ID%/, addon.id) + prop;
seems like this should just append the add-on ID and the '.' here and elsewhere

other than that looks good

Comment 7

[Dave Townsend [:mossop]]

Attachment: patch rev 2

Comments addressed

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 437336 [details] [diff] [review]
patch rev 2

Already reviewed

Comment 9

[Dave Townsend [:mossop]]

http://hg.mozilla.org/mozilla-central/rev/13b807ddb531

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marking as verified fixed based on check-in and passing automated tests.

Comment 11

[(no longer active)]

I had to disable the last part of this test on Mac because it was failing on Tinderboxes:

http://hg.mozilla.org/mozilla-central/rev/e57dc7264ff5

I filed bug 615443 about that.