Closed Bug 553123 Opened 14 years ago Closed 14 years ago

Verify that we're sending the right flags for update checks

Categories

(Toolkit :: Add-ons Manager, defect, P1)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Whiteboard: [rewrite]) 

      No description provided.
Right now the %UPDATE_TYPE% parameter is incorrect. It is variable based on the caller since the flag was defined as being a bitfield. Certain bits are a number passed in by the caller to indicate the reason for the check. Certain bits are based on whether the caller cares about compatibility updates or new versions or both. This may have to change so that we can keep the same numbers for the same types of checks for AMO's purposes.
THis is fixed by bug 554246. The UPDATE_TYPE now always includes the bit for compatibility checks and only includes the bit for update checks if the listener passed has an onUpdateAvailable method. The tests verify that we are sending the expected values as per bug 392180 comment 14.
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr]
Depends on: 554246
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
Verified fixed based on check-in and a passing automated test.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.