55323 - Wrong focus effect for classic radio icons

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P3)

Description

[[e-mail]]

The main Mail/News preference panel has two radio icons displaying the choice of
three pane layout. When one of these icons has the focus, a small dot appears to
the right of the icon. Surely the icon should have a dotted frame?

Additionally, it would be nice if the focus rectangle appears immediately around
an active radio button instead of waiting until it is checked.

Comment 1

[hangas]

Sending to Joe, ccing Ben.

Comment 2

[Joe Hewitt (gone)]

Looks like the focus is being put on the text box only, and not the box that 
contains text and icon.

Comment 3

[Jesse Ruderman]

*** Bug 64168 has been marked as a duplicate of this bug. ***

Comment 4

[hangas]

Themes Triage Team nsbeta1+

Comment 5

[[e-mail]]

Attachment: proposed patch

Comment 6

[timeless]

currently you're doing
<setter>
val.set(blah);
getGroup(this);
for( var i = 0; i < groupElements.length; i++ )
  if( groupElements[i] != val )
    groupElements[i].unset(blah);
</setter>
I think that you could improve speed [at the possible expense of correctness] 
by doing:
<setter>
getGroup(this);
for( var i = 0; i < groupElements.length; i++ )
  groupElements[i].unset(blah);
val.set(blah);
</setter>
however if this violates rules for any of the attributes then ignore it.

Comment 7

[[e-mail]]

That's because I copied the style from the existing code.

Comment 8

[Jesse Ruderman]

Focus indication problems affect keyboard navigation, so adding access 
keyword.  This bug is still minor or trivial though.

Comment 9

[Jesse Ruderman]

I wonder if this is the same as the problem with the back/next buttons in 
wizards.

Comment 10

[Joe Hewitt (gone)]

The following patch fixes the problems described in the first paragraph of the
opening comment -- as far as the part about the timing of the focused effect,
and the patch submitted by Neil, that should be a separate bug filed against
XPToolkit instead of Themes.

Comment 11

[Joe Hewitt (gone)]

Attachment: patch to fix themes stuff

Comment 12

[timeless]

r=timeless for 24039

Comment 13

[hangas]

a=hangas

Comment 14

[Joe Hewitt (gone)]

fixed

Comment 15

[Patty Mac]

Marking verified on windows (2001-02-21-06-Mtrunk).