553248 - waitForFocus in browser chrome tests uses SimpleTest ok(), rather than browser-test one.

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

We should override it, to do so it should avoid using the global var, as other utils in that file.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

i tested this with a b-c test, and now waitForFocus really logs information.
Ideally they should be looged to an info() but simpleTest does not have such a thing.

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 433301 [details] [diff] [review]
patch v1.0

Looks ok to me, assuming it works.

>+    // Override SimpleTest methods with our own.
>+    ["ok", "is", "isnot", "todo", "todo_is", "todo_isnot"].forEach(function(m) {
>+      this.currentTest.scope.SimpleTest[m] = this.currentTest.scope[m];
>+    }, this);

How about:

    ...
      this.SimpleTest[m] = this[m];
    }, this.currentTest.scope);

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

well it works, at least in the b-c test i built to check that i was getting TEST-PASS: waiting for focus and so on.

about the code change, nice trick, will do.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.1

added dao's suggestion. thanks.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/bdb90006f262

so, i hope this can help figuring out remaining waitForFocus hangs.