553334 - [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavHistoryResult.removeObserver]" when adding a new folder

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marcia Knous [:marcia]]

Seen while running Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a4pre) Gecko/20100318 Minefield/3.7a4pre

STR:
1. Add a new folder to the Bookmarks Toolbar
2. Bookmark a site.
3. Expand the Bookmarks widget to "bookmarks toolbar"
4. Expand the widget so you can see the folders nested under the Bookmarks Toolbar
5. Try to expand the Bookmarks Toolbar widget.
6. Nothing happens and i receive the attached error.

Two extensions installed:
Weave Sync1.1true{340c2bbc-ce74-4362-90b5-7c26312808ef}Adblock Plus1.1.3true{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}

Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavHistoryResult.removeObserver]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://browser/content/places/tree.xml :: load :: line 94"  data: no]

Comment 1

[Marcia Knous [:marcia]]

I can still reproduce this using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100429 Minefield/3.7a5pre. I also get Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavHistoryResult.removeObserver]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://browser/content/places/tree.xml :: load :: line 94"  data: no] error in the console as well.

Comment 2

[Asaf Romano (gone)]

Attachment: ugh

Short story is that in certain cases treeboxobject calls setTree(null) without nulling treeboxobject's view.  That might be a bug, and it might be even wrong.

It doesn't really matter however.  When I wrote that code I forgot that we alwaysreplace the view along with the result. Thus, we never need to take care of calling removeObsever for the previous result, because setTree will do so for us.

Comment 3

[Ben Bucksch (:BenB)]

> treeboxobject calls setTree(null) without nulling treeboxobject's view.
> That might be a bug, and it might be even wrong.

File a bug?

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 448404 [details] [diff] [review]
ugh

>diff -r 9d5aa4ef9b5c browser/components/places/content/tree.xml

>+          // Observer removal is done within the view itself: When the tree
>+          // goes away, treeboxobject calls view.setTree(null), which then
>+          // calls removeObserver.

replace colon with period and double spacing.


Please file the tree widget bug if you have evidence of something not working as intended, in every case better an invalid bug than a not filed bug.

Comment 5

[Asaf Romano (gone)]

I'll file that bug whenever I understand what would be the expected behavior...

Comment 6

[Asaf Romano (gone)]

http://hg.mozilla.org/mozilla-central/rev/979fbcd8bb29