Closed
Bug 553407
Opened 15 years ago
Closed 15 years ago
typeof XPCNativeWrapper is now "function"
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: gal)
References
()
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(3 files, 1 obsolete file)
|
14.87 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
|
15.50 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.17 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The fix for bug 547314 made any class with a call hook (and no wrappedObject hook) typeof "function". XPCNativeWrapper currently does this, so returns the wrong typeof value.
I can see two ways of fixing this:
* Change js_TypeOf to somehow exclude XPCNativeWrapper.
* Split XPCNativeWrapperClass into two classes: withCall and noCall, and use the appropriate one at construction time (if we do this, then this bug should move to XPConnect).
|
Reporter | |
Comment 1•15 years ago
|
||
See the URL field for a testcase.
|
Assignee | |
Comment 2•15 years ago
|
||
Monkey break monkey fix.
Assignee: general → gal
Component: JavaScript Engine → XPConnect
QA Contact: general → xpconnect
|
|
Assignee | |
Comment 3•15 years ago
|
||
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #433452 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Attachment #433457 -
Flags: review?(mrbkap)
|
|
Reporter | |
Comment 5•15 years ago
|
||
Comment on attachment 433457 [details] [diff] [review]
patch
Thanks!
Attachment #433457 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 6•15 years ago
|
||
|
|
Assignee | |
Comment 7•15 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Comment 8•15 years ago
|
||
forgot to add the test file:
http://hg.mozilla.org/tracemonkey/rev/178f1770734d
|
||
Comment 10•15 years ago
|
||
If bug 553597 is in fact a duplicate, can we add a test testing that bug too?
|
|
Reporter | |
Comment 11•15 years ago
|
||
Attachment #435057 -
Flags: review?(bzbarsky)
|
||
Comment 12•15 years ago
|
||
as Bug 552636 blocks 1.9.3, should this too?
|
||
Comment 13•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 14•15 years ago
|
||
Comment on attachment 435057 [details] [diff] [review]
Mochitest for that
r=me. Sorry for the terrible lag here. :(
Attachment #435057 -
Flags: review?(bzbarsky) → review+
|
|
Reporter | |
Comment 15•14 years ago
|
||
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•