553482 - Add icons for buttons in download progress XBL binding

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

The buttons in the download progress don't have any icons - need to add some.

Comment 1

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Add-ons manager download icons

Attached are download progress icons in a variety of states - anything else needed here?

Comment 2

[Jennifer Morrow [:Boriss] (UX)]

I'll take ui-wanted down for now.  Final graphics are still needed on this and others, but that should probably be a separate bug

Comment 3

[Dave Townsend [:mossop]]

Is this done?

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #3)
> Is this done?

No.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #2)
> I'll take ui-wanted down for now.  Final graphics are still needed on this and
> others, but that should probably be a separate bug

Jennifer, shall we file a separate bug or what is your intention? I don't want that we forget about those icons. Why not attach the icons to that bug? Putting back uiwanted until we have a solution.

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #5)
> Jennifer, shall we file a separate bug or what is your intention? I don't want
> that we forget about those icons. Why not attach the icons to that bug? Putting
> back uiwanted until we have a solution.

Yea, all that will be in some separate bug(s) - its pretty much a separate project (since it involved all in-content pages, not just about:addons). I don't think anything has been filed yet - I believe shorlander will be filing once things are ready. And the change in visual styling seems to be significant enough that these won't be left forgotten.

Comment 8

[Justin Wood (:Callek)]

(In reply to comment #6)
> Created an attachment (id=448338) [details]
> Patch

Pushed as: http://hg.mozilla.org/mozilla-central/rev/e079f587a584

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100605 Minefield/3.7a5pre