Attach existing AddonInstall upgrades to existing addon items

VERIFIED FIXED in mozilla1.9.3a5

Status

()

VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Unfocused, Assigned: Unfocused)

Tracking

Trunk
mozilla1.9.3a5
Points:
---
Bug Flags:
in-testsuite ?
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [rewrite])

When the extension manager is openned and there are exsting upgrade AddonInstalls in progress, they are not associated to their corresponding addon. As such, there is no indication that any upgrade is in fact taking place.

Note: this is *not* the case for AddonInstalls that are new installs - these do appear in the UI.
Fixing bug 553967 made this a lot easier.

http://hg.mozilla.org/projects/addonsmgr/rev/f06fe80c963c
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr]
Assignee: nobody → bmcbride
Flags: in-testsuite?
Flags: in-litmus?
Landed on trunk as a part of bug 554007
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
Blair, can you explain your comment 0 a bit more in detail, so I can check if it is completely fixed? Also would this fix need tests - manual vs. automatic? Thanks.
When upgrading an addon, there shouldn't be a separate item in the list for the install. Instead, the existing addon (that will be upgraded by the install) will display the download and install progress.

Before this was fixed, addon upgrades were not shown in any way in the UI.

Not sure if this can be automatically tested reliably (specifically, that the progress shows correctly) - would be good to get manual testing with this one.
Thanks Blair. Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100514 Minefield/3.7a5pre

A Litmus test will be added next week.
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
Don't think it is worth spending time on manually testing this case. An automatic test would be nice but is not a priority.
Flags: in-litmus? → in-litmus-
You need to log in before you can comment on or make changes to this bug.