55352 - Addressbook not migrated

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P2)

Description

[Suresh Duddi (gone)]

Here is some info for you. The only wierd thing is that I have named my
addressbook dp-abook in 4.* rather than the default name.

I deleted .mozilla and did ./netscape -installer on beta3 bits. Here is how my
.mozilla/dp looks like:

% ls -l dp-*

-rw-r--r--   1 dp       wheel      933888 Oct  4 12:38 dp-abook-old.na2
-rw-rw-r--   1 dp       wheel       82795 Oct  4 12:38 dp-abook.ldif
-rw-r--r--   1 dp       wheel     1130496 Oct  4 12:38 dp-abook.na2
% grep pab prefs.js

user_pref("ldap_2.servers.pab.csid", "iso-8859-1");
user_pref("ldap_2.servers.pab.filename", "dp-abook.na2");
user_pref("ldap_2.servers.pab.locale", "C");
user_pref("ldap_2.servers.pab.replication.lastChangeNumber", 0);
user_pref("mail.imap.server.nsmail-2.capability", 31551);
user_pref("mail.server.server1.capability", 31551);
% ls -l abook*

-rw-r--r--   1 dp       wheel       97176 Oct  4 12:38 abook.nab
-rw-rw-r--   1 dp       wheel      393216 Oct  4 12:38 abookPAB.na2

Looks like the ldif file was generated alright. And even the addressbook was
migrated ok. Why is there a abookPAB.na2 It is never referenced by the pref.
There is an old abookPAB.na2 left over in my 4.* profile directory that is never
used. Could that haves caused it.

Comment 1

[Suresh Duddi (gone)]

Marking rtm. This is more complicated by the fact that addressbook import
doesn't work.

Comment 2

[(not reading, please use [e-mail] instead)]

egads, addressbook import doesn't work?  is there a bug on that?

Comment 3

[Suresh]

Seth, AB import bug is 52086.

Comment 4

[(not reading, please use [e-mail] instead)]

accepting.  investigating.

Comment 5

[(not reading, please use [e-mail] instead)]

hmm, I'm not able to reproduce this.  I'll go debug on dp's machine to see
what's going on.

Comment 6

[chuang]

Seth, I'm working on bug 50584 which may not related to this bug.  Just 
let you know in case they are related.

Comment 7

[(not reading, please use [e-mail] instead)]

ok, I've got dp's .netscape directory, and I'm able to reproduce this.

investigating.

Comment 8

[scottputterman]

marking [rtm need info]  If you figure out what's causing it before fixing it, 
can you update the bug.  If it's something rare we may not want to proceed.

Comment 9

[(not reading, please use [e-mail] instead)]

ok, I have a fix.  the problem is once we fail to upgrade a 4.x addressbook,
we'll never succeed after that since we aren't resetting m_status.

dp has multiple address books, and we failed on an early one, so we failed to
migrate the rest of them.

it's a simple one line fix.

I'll attach the patch.

r=bienvenu
sr=mscott

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: here's the fix

Comment 11

[scottputterman]

changing priority.

Comment 12

[Michael La Guardia]

marking rtm++

Comment 13

[(not reading, please use [e-mail] instead)]

fix checked in on the branch and the tip.

Comment 14

[Suresh]

Verified on today's linux branch build. 

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

Per Suresh's comments, marking VERIFIED.