553553 - We shouldn't be using terms.Bugzilla in the "please contribute" message

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Gervase Markham [:gerv]]

Currently:

"Note: MyCompany is developed entirely by volunteers. The best way to give back to the MyCompany project is to contribute yourself!"

I expected this not to change when I customised the name of the Bugzilla.

Gerv

Comment 1

[Matt Selsky [:selsky]]

Attachment: v1

Comment 2

[Matt Selsky [:selsky]]

Should we leave Bugzilla as Bugzilla on all admin pages and the release notes?

Comment 3

[Marc Schumann [:Wurblzap]]

Comment on attachment 636017 [details] [diff] [review]
v1

r=Wurblzap.

(In reply to Matt Selsky [:selsky] from comment #2)
> Should we leave Bugzilla as Bugzilla on all admin pages and the release
> notes?

The admin pages probably need to be looked at case by case ("If you set this param to on, Bugzilla will..." will need to use the customized name, "This is by design a core Bugzilla functionality" must not be customized).

I agree that the release notes should leave Bugzilla as Bugzilla throughout.

Comment 4

[Marc Schumann [:Wurblzap]]

Oh, and on check-in, please fix the line wrapping a little so that it doesn't break the 80 character line length so much.

Comment 5

[Frédéric Buclin]

Comment on attachment 636017 [details] [diff] [review]
v1

>+          B[% %]ugzilla is developed entirely by volunteers. The best way to give

If there are many places which need to be fixed, I think it would make more sense to have a new [% terms.Bugzilla_product %] variable which really points to "Bugzilla". A comment in global/variables.none.tmpl would explain that this variable should be not altered at all, and that it should contain the real name of the product, i.e. "Bugzilla". If one day Mozilla has or wants to change the name of the product, then this would be the variable to alter. Using [% %] everywhere is a ugly hack.

Comment 6

[Gervase Markham [:gerv]]

Instead of a term which isn't actually a variable term, which is a bit strange, can't we just do:

[% "Bugzilla" %]

? AFAIK that works, and it won't get caught by the filter test.

Gerv

Comment 7

[Frédéric Buclin]

(In reply to Gervase Markham [:gerv] from comment #6)
> Instead of a term which isn't actually a variable term, which is a bit
> strange, can't we just do:
> 
> [% "Bugzilla" %]

No, because this will fail once bug 233282 is fixed.

Comment 8

[Gervase Markham [:gerv]]

I think the conclusion you just reached in bug 276202 applies also to bug 233282 - it couldn't be done without too many false positives.

Gerv

Comment 9

[Matt Selsky [:selsky]]

About 75%  of the instances of terms.Bugzilla seem to refer to the product, not the site, since they're on the admin pages or the release notes.  Should we create a new variable terms.site and change terms.Bugzilla to terms.site as needed?

Comment 10

[Marc Schumann [:Wurblzap]]

Can we please move this over to a new bug, and refer to it from here?

Comment 11

[Frédéric Buclin]

(In reply to Marc Schumann [:Wurblzap] from comment #10)
> Can we please move this over to a new bug, and refer to it from here?

Sure. Note that I already approved this bug. The reviewer (aka wurblzap) is free to commit it. ;)

Comment 12

[Marc Schumann [:Wurblzap]]

All right :)

Trunk:
Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/admin/params/editparams.html.tmpl
Committed revision 8282.

And a fix (sorry):
Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/admin/params/editparams.html.tmpl
Committed revision 8283.

Branch:
Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified template/en/default/admin/params/editparams.html.tmpl
Committed revision 8101.