Minifying CSS files in css/zamboni breaks relative URLs

VERIFIED FIXED in 5.8

Status

VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: jbalogh, Assigned: jbalogh)

Tracking

Details

(Whiteboard: [z], URL)

(Assignee)

Description

9 years ago
media/css/zamboni/zamboni.css thinks it needs to go to ../../img to find images.  This is not true when it gets compressed into media/css/common.css.  Easy fix is to make a separate zamboni bundle that gets served from media/css/zamboni/bundle.css.
(Assignee)

Comment 1

9 years ago
http://github.com/jbalogh/zamboni/commit/d04fe09bf50f5ca0f97401e7df9d922c7b837ce4
Assignee: nobody → jbalogh
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: 5.9 → 5.8
Does this need to be verified by QA, and if so, how?  Thx.
(Assignee)

Comment 3

9 years ago
If you can see the icons on the buttons, this is fixed.  They're addressed with relative urls from zamboni/zamboni.css.
Verified FIXED on https://preview.addons.mozilla.org/z/en-US/firefox/addons/smorgasbord; also checked the Net panel in Firebug, to make sure all referenced files were being loaded.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.